Skip to content

Better error message around us choosing what binding to use #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knaperek merged 8 commits into from
Apr 14, 2017
Merged

Better error message around us choosing what binding to use #51

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
273e545
Better error message on unsupported bindings
liquidpele Apr 10, 2017
7cf6f79
Use a proper Exception and not NotImplemented
liquidpele Apr 10, 2017
d515d6c
Merge remote-tracking branch 'upstream/master' into liquidpele-patch-2
Apr 10, 2017
675dc38
Intelligently pick SSO binding based on IDP metadata instead of only …
Apr 12, 2017
4c259f8
Use logger variable arguments
Apr 12, 2017
bd44fc0
Fix unit tests by passing conf we already had, not sure why get_confi…
Apr 12, 2017
ce05d8f
python 3.5+ apparnelty returns a dict_keys object from .keys() so acc…
Apr 12, 2017
9abd86f
Merge remote-tracking branch 'upstream/master' into liquidpele-patch-2
Apr 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use logger variable arguments
  • Loading branch information
Reece authored and Reece committed Apr 12, 2017
commit 4c259f87a2a396627c837ac9c0854452bbd5b7e6
14 changes: 7 additions & 7 deletions djangosaml2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,21 +163,21 @@ def login(request,
# ensure our selected binding is supported by the IDP
supported_bindings = get_idp_sso_supported_bindings(selected_idp)
if binding not in supported_bindings:
logger.debug('Binding %s not in IDP %s supported bindings: %s' % (
binding, selected_idp, supported_bindings))
logger.debug('Binding %s not in IDP %s supported bindings: %s',
binding, selected_idp, supported_bindings)
if binding == BINDING_HTTP_POST:
logger.warning('IDP %s does not support %s, trying %s' % (
selected_idp, binding, BINDING_HTTP_REDIRECT))
logger.warning('IDP %s does not support %s, trying %s',
selected_idp, binding, BINDING_HTTP_REDIRECT)
binding = BINDING_HTTP_REDIRECT
if sign_requests:
sign_requests = False
logger.warning('sp_authn_requests_signed is True, but ignoring because pysaml2 does not support it for %s' % BINDING_HTTP_REDIRECT)
logger.warning('sp_authn_requests_signed is True, but ignoring because pysaml2 does not support it for %s', BINDING_HTTP_REDIRECT)
else:
binding = BINDING_HTTP_POST
# if switched binding still not supported, give up
if binding not in supported_bindings:
raise UnsupportedBinding('IDP does not support %s or %s' % (
BINDING_HTTP_POST, BINDING_HTTP_REDIRECT))
raise UnsupportedBinding('IDP does not support %s or %s',
BINDING_HTTP_POST, BINDING_HTTP_REDIRECT)

client = Saml2Client(conf)
try:
Expand Down