Skip to content

Conversation

@ItsJonQ
Copy link
Owner

@ItsJonQ ItsJonQ commented Jan 22, 2021

Screen Shot 2021-01-22 at 10 41 24 AM

This update fixes the downshift useSelect integration with SelectDropdown.
Previously, aria-expanded would only be added after an interaction with the dropdown.
We need the reference element (button) to have aria-expanded from it's initial render.

@vercel
Copy link

vercel bot commented Jan 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/itsjonq/g2/q1e24etvx
✅ Preview: https://g2-git-fix-select-dropdown-initial-aria-expanded.itsjonq.vercel.app

@ItsJonQ ItsJonQ added the bug Something isn't working label Jan 22, 2021
@ItsJonQ ItsJonQ merged commit fc2145e into main Jan 22, 2021
@ItsJonQ ItsJonQ deleted the fix/select-dropdown-initial-aria-expanded branch January 22, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y bug Something isn't working components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants