FontSizeControl (Next): Fix SelectDropdown voiceover focus issues #28408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsJonQ
added
[Focus] Accessibility (a11y)
|
Size Change: -9.58 kB (-1%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
Contributor
|
@ItsJonQ Looking good. Only one of the items I mentioned still seems to be an issue. When the Font Size dropdown (button element) initially receives focus it doesn't seem to have the Compared to when the dropdown has been toggled open and closed at least once: |
Author
|
@talldan Wonderful!! Thank you for that feedback 🙏 |
Member
|
Reakit is deduplicated now 🎉 |
Author
|
@talldan + @diegohaz Fixing it here: Will create a release and make an update in this PR as soon as I can 🙏 |
Author
|
@gziolo Hmm! It looks like there's something in the latest rtlcss V3.0.0 that's causing issues with babel (specifically with https://github.com/WordPress/gutenberg/runs/1750693127?check_suite_focus=true |
Member
I can see it in the source of the package. It looks like they write code to target code in Node.js mostly. It looks like @jsnajdr was right that it's inevitable that we will have to start transpiling some of the packages in |
Author
|
Not sure what to do with the failing E2E test :(. I think there's something to it, but I'm not sure what. Replicating the actions locally, it works as expected. Running it locally, the "reset" related ones pass for me. There's another failure, but that's related to the theme's font setting for what a "small" size (test is looking for
|
Author
|
cc'ing @gziolo. Would you know what we can do for the E2E failure? The hardest thing is that it's inconsistent between my local machine and what's on Github actions |
added 3 commits
February 2, 2021 14:16
Update @wp-g2 packages to the latest v0.0.146
gziolo
force-pushed
the
fix/font-size-picker-next-a11y
branch
from
16e63df to
1a30b14
Compare
Member
|
I rebased this branch. It fails for me locally for the following test:
It passes in the interactive mode. There needs to be something wrong with the data propagation when the check is done very quickly. The one you mentioned that fails for you, it passes for me 🤷🏻 It fails locally when you run an interactive mode but without delay: npm run test-e2e packages/e2e-tests/specs/editor/various/font-size-picker.test.js -- --puppeteer-interactive --puppeteer-slowmo=1You can record it and check it in slow motion what happened. I need to relocate now :) |
Author
|
This should be resolved in #28707. |
Author
|
Resolved in #28707 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes the voiceover focus interactions for the (next)
FontSizeControlcomponent (recently merged #27594)The solution was to update to the latest
@wp-g2version (v0.0.143):https://github.com/ItsJonQ/g2/releases
These changes include updates to
z-indexand interaction fixes to the underlyingSelectDropdowncomponent (ItsJonQ/g2#239).Potentially resolves #28411
How has this been tested?
Tested locally on Gutenberg with Chrome + Firefox + Voiceover (Mac OS)
Also tested in the
@wp-g2pull request in a similar manner.To test:
npm run devChecklist: