Skip to content

Conversation

@ararslan
Copy link
Member

@ararslan ararslan commented Oct 15, 2018

This PR includes multiple distinct commits, two of which upstream local Nabla changes:

  1. Extend inv from Base instead of defining a new one
  2. Implement exp10 for Dual (taken from a change made in Nabla)
  3. Extend value and epsilon to normal numbers (taken from a change made in Nabla)
  4. Fix coverage submission for the Pkg3 new world order

Will's authorship has been preserved for the Nabla commits, so please do not squash the commits.

ararslan and others added 4 commits October 15, 2018 14:07
This fixes a MethodError observed in Nabla. It seems to have been an
oversight.
The ɛ component is 0 for all non-dual numbers, and the value is equal to
itself.
@dlfivefifty dlfivefifty merged commit 6c2d651 into JuliaDiff:master Oct 16, 2018
@ararslan ararslan deleted the aa/some-fixes branch October 16, 2018 15:50
@ararslan
Copy link
Member Author

Thanks! Would you be willing to tag a new release, @dlfivefifty?

@dlfivefifty
Copy link
Collaborator

Sure.

I'm not sure who's "in charge" of maintaining this package, but maybe we could get you added? @mlubin I don't have enough rights to do that so could you add @ararslan?

@mlubin
Copy link
Contributor

mlubin commented Oct 16, 2018

@dlfivefifty I granted you admin access.

@dlfivefifty
Copy link
Collaborator

Thanks! I've added @ararslan as a collaborator, feel free to tag a release when ready.

@ararslan
Copy link
Member Author

Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants