Skip to content

Grab bag of minor changes #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlfivefifty merged 4 commits into from
Oct 16, 2018
Merged

Grab bag of minor changes #68

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6830076
Extend Base.inv
ararslan Oct 15, 2018
542cfbe
Implement exp10 for Dual
willtebbutt Oct 15, 2018
8946805
Extend value and epsilon to work on non-Duals
willtebbutt Oct 15, 2018
36715a9
0.7-compatible coverage submission from Travis
ararslan Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement exp10 for Dual 
Upstreamed from invenia/Nabla.jl#102
  • Loading branch information
@willtebbutt @ararslan
willtebbutt authored and ararslan committed Oct 15, 2018
commit 542cfbed072964678f32be7c0adbe199b8e1711c
2 changes: 2 additions & 0 deletions src/dual.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,8 @@ end
Base.exp(z::Dual) = (expval = exp(value(z)); Dual(expval, epsilon(z)*expval))
Base.cis(z::Dual) = (cisval = cis(value(z)); Dual(cisval, im*epsilon(z)*cisval))

Base.exp10(x::Dual) = (y = exp10(value(x)); Dual(y, y * log(10) * epsilon(x)))

## TODO: should be generated in Calculus
Base.sinpi(z::Dual) = Dual(sinpi(value(z)),epsilon(z)*cospi(value(z))*π)
Base.cospi(z::Dual) = Dual(cospi(value(z)),-epsilon(z)*sinpi(value(z))*π)
Expand Down
6 changes: 6 additions & 0 deletions test/automatic_differentiation_test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,3 +162,9 @@ flipsign(-1.0,Dual(1.0,1.0)) == -1.0
# test SpecialFunctions
@test erf(dual(1.0,1.0)) == dual(erf(1.0), 2exp(-1.0^2)/sqrt(π))
@test gamma(dual(1.,1)) == dual(gamma(1.0),polygamma(0,1.0))


let x = exp10(Dual(2, 0.01))
@test value(x) ≈ 100.0
@test epsilon(x) ≈ log(10)
end