Conversation
wischli
reviewed
Oct 13, 2022
| /// * associated accounts | ||
| /// * service endpoints | ||
| fn query_did(did: DidIdentifier) -> Option<RawDidLinkedInfo<DidIdentifier, AccountId, LinkableAccountId,Balance, Key, BlockNumber>>; | ||
| fn query_did(did: DidIdentifier) -> Option<RawDidLinkedInfo<DidIdentifier, AccountId, LinkableAccountId, Balance, Key, BlockNumber>>; |
Contributor
There was a problem hiding this comment.
Shouldn't we have a changed_in flag for this call as well then?
Contributor
Author
There was a problem hiding this comment.
That's true! I think all of them must be marked as deprecated. Good catch!
wischli
pushed a commit
that referenced
this pull request
Oct 17, 2022
* Remove DID RPC * Add version support for DID RPC call * Mark other DID API methods as deprecated as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows the direction that Parity is taking of removing RPC calls that do nothing but forwarding it to the runtime. Plus, RPC calls do not support versioning, while runtime calls do, and this makes it very easy for the SDK to use the right types and functions depending on the runtime API version (tested on a local script using the same type definitions to connect both to Spiritnet and to a node running this PR, and both were successful).
If this PR is merged, #421 becomes less urgent, although we should have a strategy for breaking changes at the RPC level anyway.
How it's used in the SDK
Please refer to the following commit: KILTprotocol/sdk-js@ba1c023.