Skip to content

Fix twig runtime extension last modification time detection #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stof merged 5 commits into from
Jun 13, 2025
Merged

Fix twig runtime extension last modification time detection #405

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
71d6eb4
fix twig runtime extension last modification time detection
Jun 11, 2025
828ffcf
Revert "fix twig runtime extension last modification time detection"
Jun 11, 2025
b41d686
fix twig runtime extension last modification time detection
Jun 11, 2025
8364647
simplify runtime extension path detection
Jun 11, 2025
556baf0
add test
Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add test
  • Loading branch information
Sergey Danilchenko committed Jun 11, 2025
commit 556baf01a7e96df4cfe1ce2f8f3fa89e2f335cee
8 changes: 8 additions & 0 deletions tests/Knp/Menu/Tests/Twig/MenuExtensionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,14 @@ public function testGetCurrentItem(): void
$this->assertEquals('current', $this->getTemplate('{{ knp_menu_get_current_item("default") is knp_menu_current ? "current" : "not current" }}', $helper, $matcher)->render([]));
}

public function testLastModified(): void
{
$this->assertSame(max(
filemtime((new \ReflectionClass(MenuExtension::class))->getFileName()),
filemtime((new \ReflectionClass(MenuRuntimeExtension::class))->getFileName()),
), (new MenuExtension())->getLastModified());
}

/**
* @param array<string> $methods
*/
Expand Down