Fix twig runtime extension last modification time detection #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Jun 11, 2025
Collaborator
stof
left a comment
stof
left a comment
There was a problem hiding this comment.
MenuRuntimeExtension was not marked as @internal and projects using the library have to handle instantiating it, so this PR is a BC break.
Please provide a custom implementation of getLastModified instead to achieve it without BC break.
added 2 commits
June 11, 2025 15:00
daniser
commented
Jun 11, 2025
src/Knp/Menu/Twig/MenuExtension.php
Outdated
| { | ||
| return max( | ||
| (int) filemtime(__FILE__), | ||
| (int) filemtime((string) (new \ReflectionClass(MenuRuntimeExtension::class))->getFileName()), |
Author
There was a problem hiding this comment.
Casts added to keep Phpstan happy.
Collaborator
There was a problem hiding this comment.
We could simplify this by not using reflection but using __DIR__ . '/MenuRuntimeExtension.php') instead.
garak
approved these changes
Jun 12, 2025
stof
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames Twig runtime extension fromMenuRuntimeExtension.phptoMenuRuntime.phpto follow naming convention.This allows Twig to know when to recompile template(s) if extension code has changed.
This should not break BC because it is internal class not used anywhere else directly (correct me if I'm wrong).
This PR provides custom
MenuExtension::getLastModifiedmethod implementation. This allows Twig to know when to recompile template(s) if extension code has changed.