Skip to content

chore: add minimal chart version requirement #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vl-kp wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: add minimal chart version requirement #55

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
431588c
chore: add minimal chart version requirement
vl-kp Jun 20, 2025
096b238
chore: omit name and version in chart-dev
vl-kp Jun 20, 2025
fd4a84e
add exception for tab
vl-kp Jun 20, 2025
34a0fd6
revert
vl-kp Jun 20, 2025
cabcbf5
Merge branch 'main' into chore/add-minimal-chart-version-validation
vl-kp Oct 15, 2025
c3a349d
Update gitops_values_validation.py
vl-kp Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: omit name and version in chart-dev
  • Loading branch information
@vl-kp
vl-kp committed Jun 20, 2025
commit 096b2385b7b8989969f7b333bfbfb34a71700cfc
4 changes: 2 additions & 2 deletions kp_pre_commit_hooks/gitops_values_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,8 @@ def platform_managed_chart_version(self) -> Optional[str]:
def from_chart_file(chart_file: Path):
chart = cast(dict, yaml.safe_load(chart_file.read_text()))
return HelmChart(
name=chart["name"],
version=chart["version"],
name=chart.get("name", ""),
version=chart.get("version", ""),
dependencies=[HelmChart(dep["name"], dep["version"]) for dep in chart.get("dependencies", [])],
)

Expand Down