Skip to content

chore: add minimal chart version requirement #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vl-kp wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: add minimal chart version requirement #55

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
431588c
chore: add minimal chart version requirement
vl-kp Jun 20, 2025
096b238
chore: omit name and version in chart-dev
vl-kp Jun 20, 2025
fd4a84e
add exception for tab
vl-kp Jun 20, 2025
34a0fd6
revert
vl-kp Jun 20, 2025
cabcbf5
Merge branch 'main' into chore/add-minimal-chart-version-validation
vl-kp Oct 15, 2025
c3a349d
Update gitops_values_validation.py
vl-kp Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert
  • Loading branch information
@vl-kp
vl-kp committed Jun 20, 2025
commit 34a0fd681675d2b7315cfcf9adb0fd5412dee3e5
11 changes: 1 addition & 10 deletions kp_pre_commit_hooks/gitops_values_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
from jsonschema_specifications import REGISTRY
from referencing import Registry, Resource
from termcolor import colored
from yaml.scanner import ScannerError

# Disable insecure request warnings
urllib3.disable_warnings(urllib3.exceptions.InsecureRequestWarning)
Expand Down Expand Up @@ -420,15 +419,7 @@ def iter_chart_validation_errors(self) -> Iterator[SchemaValidationError]:
if not chart_file_path.exists():
continue

try:
helm_chart = HelmChart.from_chart_file(chart_file_path)
except ScannerError as e:
yield SchemaValidationError(
f"Invalid YAML: {e.problem}",
location=f"file {chart_file_path.relative_to(self.service_instance_config.gitops_repository.gitops_path)} at line {e.problem_mark.line + 1}",
hint="YAML does not allow tab characters. Please use spaces for indentation."
)
continue # Skip further checks on this broken file
helm_chart = HelmChart.from_chart_file(chart_file_path)

chart_version_str = helm_chart.platform_managed_chart_version
if chart_version_str:
Expand Down