Skip to content

Conversation

@jasp00
Copy link
Member

@jasp00 jasp00 commented Feb 16, 2017

Allow switches among branches without removing the local repository, per #198 (comment).

Do not merge until the task that updates CONTRIBUTORS is fixed.

@jasp00
Copy link
Member Author

jasp00 commented Feb 16, 2017

#215 should be tested first.

@tresf
Copy link
Member

tresf commented Feb 16, 2017

Do not merge until the task that updates CONTRIBUTORS is fixed.

If you just keep it maintenance-tasks repo, we can merge this anytime, right?

@jasp00
Copy link
Member Author

jasp00 commented Feb 16, 2017

If you just keep it maintenance-tasks repo, we can merge this anytime, right?

Correct. You may merge.

@tresf tresf merged commit e48f0da into LMMS:master Feb 19, 2017
@tresf
Copy link
Member

tresf commented Feb 19, 2017

@jasp00 latest error:

M       doc/CONTRIBUTORS
Already on 'maintenance-test'
Your branch is behind 'origin/maintenance-test' by 1 commit, and can be fast-forwarded.
error: Your local changes to the following files would be overwritten by merge:
        doc/CONTRIBUTORS
Please, commit your changes or stash them before you can merge.
Aborting

@jasp00 jasp00 deleted the tasks-lmms branch March 16, 2017 22:43
@jasp00
Copy link
Member Author

jasp00 commented Mar 16, 2017

OK, there are many possible errors to recover from. I will wipe out the local repository on error for the sake of simplicity.

@tresf
Copy link
Member

tresf commented Mar 16, 2017

I will wipe out the local repository on error for the sake of simplicity.

What is the difference between that and forcing the commit through?

@jasp00
Copy link
Member Author

jasp00 commented Mar 18, 2017

What is the difference between that and forcing the commit through?

Do you mean to force git merge? How do you do that?

Also, git checkout may fail.

@tresf
Copy link
Member

tresf commented Mar 18, 2017

I think this will do it if we call it immediately following the fetch...

git reset --hard origin/$BRANCH

It won't merge origin's HEAD but rather clobber whatever the webserver has.

Since we are overwriting the entire file each job, each time, this should be OK and will only pull deltas without forcing a clone every time.

@jasp00
Copy link
Member Author

jasp00 commented Mar 19, 2017

git reset --hard origin/$BRANCH

But this forces to run the tasks every time. You cannot detect if you were up-to-date this way.

@tresf
Copy link
Member

tresf commented Mar 20, 2017

You cannot detect if you were up-to-date this way.

Good point but won't committing an identical file commit nothing?

@jasp00
Copy link
Member Author

jasp00 commented Mar 20, 2017

won't committing an identical file commit nothing?

I do not know why you make this question. You usually cannot commit without changes.

@tresf
Copy link
Member

tresf commented Mar 20, 2017

I do not know why you make this question.

Because it fixes the problem, moving Already up to date to something like no changes added to commit, no?

@jasp00
Copy link
Member Author

jasp00 commented Mar 20, 2017

moving Already up to date to something like no changes added to commit

What git sequence do you suggest to avoid the execution of the tasks?

@tresf
Copy link
Member

tresf commented Mar 26, 2017

What git sequence do you suggest to avoid the execution of the tasks?

I don't see any harm in execution each time. Do you?

@jasp00
Copy link
Member Author

jasp00 commented Mar 28, 2017

I don't see any harm in execution each time. Do you?

I do. The advantage of this system is that we can add many tasks, so they should not be executed each hour needlessly. On error, it is better to discard the environment and start from scratch.

@tresf
Copy link
Member

tresf commented Mar 28, 2017

so they should not be executed each hour needlessly

You're talking about a few CPU cycles and hourly is overkill, we could just as easily switch it to daily. However you want to tackle this is fine, but the current process is broken and in the meantime we're without CONTRIBUTORS until it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants