Add temporary directory to cloned repository #215
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop pipe in contributors task
Merged
Member
Author
|
This will only stop erasing |
Member
Author
|
When run from a cron job, |
Member
Author
|
Fixed. |
tresf
reviewed
Feb 16, 2017
Member
tresf
left a comment
tresf
left a comment
There was a problem hiding this comment.
Can we use the -pipefail flag then?
cron/tasks/lmms/02-contributors
Outdated
| set -e | ||
|
|
||
| git shortlog -sne | cut -c 8- > doc/CONTRIBUTORS | ||
| git shortlog -sne > tmp/shortlog |
Member
There was a problem hiding this comment.
can you just $var it and avoid the unnecessary mkdir/stdout/rm logic?
Member
There was a problem hiding this comment.
I tested -o pipefail and it does exactly what you're achieving without the temporary file. Merged in e326760.
Member
|
Superseded by e326760 |
Member
Author
|
|
Member
|
Bash is our defacto standard, that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop pipe in contributors task
Pipes hide some errors.