Skip to content

About dialog & export dialog improvements. #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tresf merged 14 commits into from
Nov 15, 2017
Merged

About dialog & export dialog improvements. #3826

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1c31bb5
Initial commit.
Sep 25, 2017
d1e2815
Fixes.
Sep 25, 2017
b1cc942
Some about dialog changes.
Sep 26, 2017
b2ea361
Change color of link to something green-ish.
Sep 26, 2017
0404639
Commeneted out useless code.
Sep 26, 2017
1da95ba
Formatting reverse.
Sep 27, 2017
015f4c9
Formatting reverse 2.
Sep 27, 2017
080c8b4
Formatting reverse 3.
Sep 27, 2017
4398747
Return "Involved" tab. Revert AboutDialog.cpp changes.
Sep 27, 2017
351c8ca
Commented out "Export as loop".
Sep 30, 2017
10f4924
Undo commented out "Export as loop".
Sep 30, 2017
9da7ae6
ED: (Remove end silence) -> (Remove extra bar).
Oct 26, 2017
bb43f97
Export dialog should not be resizable.
Oct 27, 2017
aa589fa
"LMMS developers" to "LMMS Developers".
Nov 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ STRING(TOUPPER "${CMAKE_PROJECT_NAME}" PROJECT_NAME_UCASE)
# Updated by maintenance tasks
SET(PROJECT_YEAR 2015)

SET(PROJECT_AUTHOR "LMMS Developers")
SET(PROJECT_AUTHOR "LMMS developers")
Copy link
Member

@tresf tresf Sep 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why lowercase here? Is this necessary change as part of this PR or was it something that was never reverted after testing?

Copy link
Member Author

@husamalhomsi husamalhomsi Nov 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the latter. I will capitalize it.

SET(PROJECT_URL "https://lmms.io")
SET(PROJECT_EMAIL "[email protected]")
SET(PROJECT_DESCRIPTION "${PROJECT_NAME_UCASE} - Free music production software")
Expand Down
34 changes: 16 additions & 18 deletions src/core/ProjectRenderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ const ProjectRenderer::FileEncodeDevice ProjectRenderer::fileEncodeDevices[] =
{

{ ProjectRenderer::WaveFile,
QT_TRANSLATE_NOOP( "ProjectRenderer", "WAV-File (*.wav)" ),
QT_TRANSLATE_NOOP( "ProjectRenderer", "WAV (*.wav)" ),
".wav", &AudioFileWave::getInst },
{ ProjectRenderer::FlacFile,
QT_TRANSLATE_NOOP("ProjectRenderer", "FLAC-File (*.flac)"),
QT_TRANSLATE_NOOP("ProjectRenderer", "FLAC (*.flac)"),
".flac",
&AudioFileFlac::getInst
},
{ ProjectRenderer::OggFile,
QT_TRANSLATE_NOOP( "ProjectRenderer", "Compressed OGG-File (*.ogg)" ),
QT_TRANSLATE_NOOP( "ProjectRenderer", "OGG (*.ogg)" ),
Copy link
Member

@lukas-w lukas-w Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, can we make this say "Ogg-Vorbis" instead? This would correctly reflect the fact that Ogg is merely the container format, while Vorbis is the audio codec that's being used here.

Copy link
Member

@tresf tresf Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From wikipedia.org:

Before 2007, the .ogg filename extension was used for all files whose content used the Ogg container format. Since 2007, the Xiph.Org Foundation recommends that .ogg only be used for Ogg Vorbis audio files. The Xiph.Org Foundation decided to create a new set of file extensions and media types to describe different types of content such as .oga for audio only files, .ogv for video with or without sound (including Theora), and .ogx for multiplexed Ogg.[4]

"OGG" should be just fine.

".ogg",
#ifdef LMMS_HAVE_OGGVORBIS
&AudioFileOgg::getInst
Expand All @@ -58,16 +58,16 @@ const ProjectRenderer::FileEncodeDevice ProjectRenderer::fileEncodeDevices[] =
#endif
},
{ ProjectRenderer::MP3File,
QT_TRANSLATE_NOOP( "ProjectRenderer", "Compressed MP3-File (*.mp3)" ),
QT_TRANSLATE_NOOP( "ProjectRenderer", "MP3 (*.mp3)" ),
".mp3",
#ifdef LMMS_HAVE_MP3LAME
&AudioFileMP3::getInst
#else
NULL
#endif
},
// ... insert your own file-encoder-infos here... may be one day the
// user can add own encoders inside the program...
// Insert your own file-encoder infos here.
// Maybe one day the user can add own encoders inside the program.

{ ProjectRenderer::NumFileFormats, NULL, NULL, NULL }

Expand Down Expand Up @@ -109,15 +109,15 @@ ProjectRenderer::ProjectRenderer( const Mixer::qualitySettings & qualitySettings

ProjectRenderer::~ProjectRenderer()
{
Engine::mixer()->restoreAudioDevice(); // also deletes audio-dev
Engine::mixer()->restoreAudioDevice(); // Also deletes audio dev.
Engine::mixer()->changeQuality( m_oldQualitySettings );
}




// little help-function for getting file-format from a file-extension (only for
// registered file-encoders)
// Little help function for getting file format from a file extension
// (only for registered file-encoders).
ProjectRenderer::ExportFileFormats ProjectRenderer::getFileFormatFromExtension(
const QString & _ext )
{
Expand All @@ -131,7 +131,7 @@ ProjectRenderer::ExportFileFormats ProjectRenderer::getFileFormatFromExtension(
++idx;
}

return( WaveFile ); // default
return( WaveFile ); // Default.
}


Expand All @@ -151,9 +151,8 @@ void ProjectRenderer::startProcessing()

if( isReady() )
{
// have to do mixer stuff with GUI-thread-affinity in order to
// make slots connected to sampleRateChanged()-signals being
// called immediately
// Have to do mixer stuff with GUI-thread affinity in order to
// make slots connected to sampleRateChanged()-signals being called immediately.
Engine::mixer()->setAudioDevice( m_fileDev,
m_qualitySettings, false );

Expand Down Expand Up @@ -182,7 +181,7 @@ void ProjectRenderer::run()

Engine::getSong()->startExport();
Engine::getSong()->updateLength();
//skip first empty buffer
// Skip first empty buffer.
Engine::mixer()->nextBuffer();

const Song::PlayPos & exportPos = Engine::getSong()->getPlayPos(
Expand All @@ -193,7 +192,7 @@ void ProjectRenderer::run()
tick_t endTick = exportEndpoints.second.getTicks();
tick_t lengthTicks = endTick - startTick;

// Continually track and emit progress percentage to listeners
// Continually track and emit progress percentage to listeners.
while( exportPos.getTicks() < endTick &&
Engine::getSong()->isExporting() == true
&& !m_abort )
Expand All @@ -207,12 +206,12 @@ void ProjectRenderer::run()
}
}

// notify mixer of the end of processing
// Notify mixer of the end of processing.
Engine::mixer()->stopProcessing();

Engine::getSong()->stopExport();

// if the user aborted export-process, the file has to be deleted
// If the user aborted export-process, the file has to be deleted.
const QString f = m_fileDev->outputFile();
if( m_abort )
{
Expand Down Expand Up @@ -255,4 +254,3 @@ void ProjectRenderer::updateConsoleProgress()
}



4 changes: 2 additions & 2 deletions src/gui/AboutDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ AboutDialog::AboutDialog(QWidget* parent) :

authorLabel->setPlainText( embed::getText( "AUTHORS" ) );

licenseLabel->setPlainText( embed::getText( "LICENSE.txt" ) );
/*involvedLabel->setPlainText( embed::getText( "CONTRIBUTORS" ) );*/

involvedLabel->setPlainText( embed::getText( "CONTRIBUTORS" ) );
licenseLabel->setPlainText( embed::getText( "LICENSE.txt" ) );
}
27 changes: 13 additions & 14 deletions src/gui/ExportProjectDialog.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ ExportProjectDialog::ExportProjectDialog( const QString & _file_name,
setWindowTitle( tr( "Export project to %1" ).arg(
QFileInfo( _file_name ).fileName() ) );

// get the extension of the chosen file
// Get the extension of the chosen file.
QStringList parts = _file_name.split( '.' );
QString fileExt;
if( parts.size() > 0 )
Expand All @@ -60,16 +60,16 @@ ExportProjectDialog::ExportProjectDialog( const QString & _file_name,
{
if( ProjectRenderer::fileEncodeDevices[i].isAvailable() )
{
// get the extension of this format
// Get the extension of this format.
QString renderExt = ProjectRenderer::fileEncodeDevices[i].m_extension;

// add to combo box
// Add to combo box.
fileFormatCB->addItem( ProjectRenderer::tr(
ProjectRenderer::fileEncodeDevices[i].m_description ),
QVariant(ProjectRenderer::fileEncodeDevices[i].m_fileFormat) // format tag; later used for identification
QVariant( ProjectRenderer::fileEncodeDevices[i].m_fileFormat ) // Format tag; later used for identification.
);

// if this is our extension, select it
// If this is our extension, select it.
if( QString::compare( renderExt, fileExt,
Qt::CaseInsensitive ) == 0 )
{
Expand All @@ -84,9 +84,8 @@ ExportProjectDialog::ExportProjectDialog( const QString & _file_name,
for(int i=0; i<=MAX_LEVEL; ++i)
{
QString info="";
if (i==0){ info = tr("(fastest)"); }
else if (i==4){ info = tr("(default)"); }
else if (i==MAX_LEVEL){ info = tr("(smallest)"); }
if ( i==0 ){ info = tr( "( Fastest - biggest )" ); }
else if ( i==MAX_LEVEL ){ info = tr( "( Slowest - smallest )" ); }

compLevelCB->addItem(
QString::number(i)+" "+info,
Expand All @@ -95,7 +94,7 @@ ExportProjectDialog::ExportProjectDialog( const QString & _file_name,
}
compLevelCB->setCurrentIndex(MAX_LEVEL/2);
#ifndef LMMS_HAVE_SF_COMPLEVEL
//Disable this widget; the setting would be ignored by the renderer.
// Disable this widget; the setting would be ignored by the renderer.
compressionWidget->setVisible(false);
#endif

Expand Down Expand Up @@ -175,8 +174,8 @@ void ExportProjectDialog::startExport()
os.setCompressionLevel(level);
}

//Make sure we have the the correct file extension
//so there's no confusion about the codec in use.
// Make sure we have the the correct file extension
// so there's no confusion about the codec in use.
auto output_name = m_fileName;
if (!(m_multiExport || output_name.endsWith(m_fileExtension,Qt::CaseInsensitive)))
{
Expand All @@ -190,9 +189,9 @@ void ExportProjectDialog::startExport()
connect( m_renderManager.get(), SIGNAL( progressChanged( int ) ),
progressBar, SLOT( setValue( int ) ) );
connect( m_renderManager.get(), SIGNAL( progressChanged( int ) ),
this, SLOT( updateTitleBar( int ) )) ;
this, SLOT( updateTitleBar( int ) ));
connect( m_renderManager.get(), SIGNAL( finished() ),
this, SLOT( accept() ) );
this, SLOT( accept() ) ) ;
connect( m_renderManager.get(), SIGNAL( finished() ),
gui->mainWindow(), SLOT( resetWindowTitle() ) );

Expand Down Expand Up @@ -250,7 +249,7 @@ void ExportProjectDialog::startBtnClicked()
{
m_ft = ProjectRenderer::NumFileFormats;

//Get file format from current menu selection.
// Get file format from current menu selection.
bool successful_conversion = false;
QVariant tag = fileFormatCB->itemData(fileFormatCB->currentIndex());
m_ft = static_cast<ProjectRenderer::ExportFileFormats>(
Expand Down
Loading