fix sample track out of sync with jack on 48000 hz #4975
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BaraMGB
added
the
needs code review
Member
|
For whatever my code review is worth: No cosmetic issues since you're just replacing the function called, no concern about the actual logic of the fix either. Have you tested if this fix works with oversampling enabled? Just as a note-to-self: If that were to fail, outputSampleRate() might be the way to go. |
Spekular
approved these changes
May 24, 2019
Spekular
requested changes
May 25, 2019
| void SampleBuffer::normalizeSampleRate( const sample_rate_t _src_sr, | ||
| bool _keep_settings ) | ||
| { | ||
| // do samplerate-conversion to our default-samplerate |
Member
There was a problem hiding this comment.
Suggested change
| // do samplerate-conversion to our default-samplerate | |
| // do samplerate-conversion to our processing-samplerate |
Member
There was a problem hiding this comment.
On second thought, this comment should be changed, unless this line was changed by mistake.
Contributor
Author
|
I close this in favor of a solution of @Reflexe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4786