SampleBuffer -> Samplerate - Fix two sample rate issues: #4991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reflexe
added
the
needs code review
BaraMGB
suggested changes
May 28, 2019
Contributor
Contributor
|
#4786 is not fixed with this PR. 😕 I guess, the sample on the sample track is played with its own samplerate. I exported a clicktrack (with 44100) and loaded it to the sample track. My Jack runs with 48000 Hz. The click and the sample aren't in sync anymore. |
Member
Author
|
Ok, I've found the right commit. However, I can't understand how your solution has solved it? :\ |
Reflexe
force-pushed
the
fix/sample_rate_fix
branch
2 times, most recently
from
6f314c2 to
f0e344f
Compare
BaraMGB
reviewed
May 29, 2019
Member
Author
|
Thanks! I'll look into that in a few hours.
…On Wed, 29 May 2019, 11:47 Steffen Baranowsky, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/core/SampleBuffer.cpp
<#4991 (comment)>:
> @@ -1196,7 +1201,7 @@ SampleBuffer * SampleBuffer::resample( const sample_rate_t _src_sr,
src_data.data_out = dst_buf[0];
src_data.input_frames = frames;
src_data.output_frames = dst_frames;
- src_data.src_ratio = (double) _dst_sr / _src_sr;
+ src_data.src_ratio = (double) _src_sr / _dst_sr;
My Jack is running on 48Khz. I have a click track. I export the project
*.wav with 44,1 khz. I insert the *.wav to a sample track. It isn't in sync:
[image: Bildschirmfoto von 2019-05-29 10-37-38]
<https://user-images.githubusercontent.com/6502580/58543012-dc58e380-81fe-11e9-9c4f-fee53f266c06.png>
If I revert this line (_dst_sr / _src_sr) it is in sync:
[image: Bildschirmfoto von 2019-05-29 10-39-19]
<https://user-images.githubusercontent.com/6502580/58543102-08746480-81ff-11e9-9fee-e08991831025.png>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#4991?email_source=notifications&email_token=AFOMGKCRTHMBXKI5NG4IKNTPXY7J7A5CNFSM4HPVG4AKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBZ63ARQ#pullrequestreview-243118150>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFOMGKFLPCHJROEUMPSEOWDPXY7J7ANCNFSM4HPVG4AA>
.
|
Reflexe
force-pushed
the
fix/sample_rate_fix
branch
from
f0e344f to
fedcd9a
Compare
Member
Author
|
Oky dooky, I think we are good now (I fixed that in another commit probably :) Thanks for your help! |
Reflexe
force-pushed
the
fix/sample_rate_fix
branch
from
fedcd9a to
c9e457c
Compare
BaraMGB
suggested changes
Jun 2, 2019
Contributor
BaraMGB
left a comment
BaraMGB
left a comment
There was a problem hiding this comment.
The issue is fixed with this PR, now. After fixing these 2 style issues I vote for merge.
SampleBuffer was using baseSampleRate as the default samplerate instead of the actual processingSampleRate.
played correctly after saving and loading a project due to sample rate not getting saved in the project file.
right place when it not played from the begining. That has created a difference between the ticks and the metronome and the sample track. The cause of the problem was that the calculation of the frame to play was wrong: we had calculated `framesPerTick` according to the current engine's sample rate instead of the SampleBuffer's sample rate.
Reflexe
force-pushed
the
fix/sample_rate_fix
branch
from
c9e457c to
78b0652
Compare
Member
Author
|
Since it isn't a single issue, I'll rebase it instead of squashing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of the actual processingSampleRate.
Closes #4786