Skip to content

Conversation

@JohannesLorenz
Copy link
Contributor

@JohannesLorenz JohannesLorenz commented Nov 8, 2020

Hotfix for #5767. Implement a blacklist and add the SWH GLAME Lv2 filters to it.

This is just temporary, but I think it's important to take those filters out before more users hear that noise.

Reviewer hints:

  1. The implementation may not be 100% perfect:
    a. it should be in the core, not restricted to Lv2
    b. a blacklist should be more general, as suggested in Plugin blacklist #5771
  2. Wait for CI before review

Tester hints:

  1. This PR does not require testing IMO, I tested the few bits myself. However, if you really want to test anything: Make sure you use "dummy audio output" in the LMMS settings and have restarted before. The audio produced by those effects is horrible.

@JohannesLorenz JohannesLorenz added the needs code review A functional code review is currently required for this PR label Nov 8, 2020
@LmmsBot
Copy link

LmmsBot commented Nov 8, 2020

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://10481-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.8%2Bg9fc7c93-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10481?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://10482-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.8%2Bg9fc7c9376-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10482?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://10484-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.8%2Bg9fc7c9376-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10484?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://10480-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.8%2Bg9fc7c9376-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10480?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "e17cce8aa13ff9f86d54e541e6d9f1246f67b1da"}

@JohannesLorenz
Copy link
Contributor Author

As this is a fix for a critical issue, I'll merge this without review in 3 days unless anyone has objections.

@PhysSong
Copy link
Member

Please don't merge this now. I figured out the cause of it.

@zonkmachine
Copy link
Contributor

I have a hunch the blacklist function will come in handy again later anyway. It's quite handy to have the option to temporarily remove plugins that cause trouble while we develop this.

@JohannesLorenz
Copy link
Contributor Author

Agreed to both of you. It should not be merged like this. However, e.g. Calf Analyzer and Calf Bass Enhancer cause crashes, so I'lll remove the GLAME filters (handled by #5783) and add those Calf effects.

@JohannesLorenz JohannesLorenz merged commit 48bc9db into LMMS:master Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs code review A functional code review is currently required for this PR

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants