-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Blacklist SWH GLAME filters for Lv2 #5774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩
Linux
Windows
macOS🤖{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://10481-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.8%2Bg9fc7c93-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10481?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://10482-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.8%2Bg9fc7c9376-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10482?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://10484-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.8%2Bg9fc7c9376-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10484?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://10480-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.8%2Bg9fc7c9376-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10480?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "e17cce8aa13ff9f86d54e541e6d9f1246f67b1da"} |
|
As this is a fix for a critical issue, I'll merge this without review in 3 days unless anyone has objections. |
|
Please don't merge this now. I figured out the cause of it. |
|
I have a hunch the blacklist function will come in handy again later anyway. It's quite handy to have the option to temporarily remove plugins that cause trouble while we develop this. |
|
Agreed to both of you. It should not be merged like this. However, e.g. Calf Analyzer and Calf Bass Enhancer cause crashes, so I'lll remove the GLAME filters (handled by #5783) and add those Calf effects. |
0e35fab to
e17cce8
Compare
Hotfix for #5767. Implement a blacklist and add the SWH GLAME Lv2 filters to it.
This is just temporary, but I think it's important to take those filters out before more users hear that noise.
Reviewer hints:
a. it should be in the core, not restricted to Lv2
b. a blacklist should be more general, as suggested in Plugin blacklist #5771
Wait for CI before reviewTester hints: