Blacklist SWH GLAME filters for Lv2

include/Engine.h

@@ -88,6 +88,8 @@ class LMMS_EXPORT LmmsCore : public QObject
 		return s_projectJournal;
 	}
 
+	static bool ignorePluginBlacklist();
+
 #ifdef LMMS_HAVE_LV2
 	static class Lv2Manager * getLv2Manager()
 	{

include/Lv2Manager.h

@@ -131,6 +131,11 @@ class Lv2Manager
 	}
 	bool isFeatureSupported(const char* featName) const;
 
+	static const std::set<const char*, Lv2Manager::CmpStr>& getPluginBlacklist()
+	{
+		return pluginBlacklist;
+	}
+
 private:
 	// general data
 	bool m_debug; //!< if set, debug output will be printed
@@ -144,6 +149,9 @@ class Lv2Manager
 	// URID cache for fast URID access
 	Lv2UridCache m_uridCache;
 
+	// static
+	static const std::set<const char*, Lv2Manager::CmpStr> pluginBlacklist;
+
 	// functions
 	bool isSubclassOf(const LilvPluginClass *clvss, const char *uriStr);
 };

include/PluginIssue.h

@@ -44,6 +44,7 @@ enum PluginIssueType
 	portHasNoMax,
 	featureNotSupported, //!< plugin requires functionality LMMS can't offer
 	badPortType, //!< port type not supported
+	blacklisted,
 	noIssue
 };
 
@@ -60,6 +61,7 @@ class PluginIssue
 		: m_issueType(it), m_info(msg)
 	{
 	}
+	PluginIssueType type() const { return m_issueType; }
 	friend QDebug operator<<(QDebug stream, const PluginIssue& iss);
 };
 

src/core/Engine.cpp

@@ -116,6 +116,18 @@ void LmmsCore::destroy()
 	delete ConfigManager::inst();
 }
 
+
+
+
+bool LmmsCore::ignorePluginBlacklist()
+{
+	const char* envVar = getenv("LMMS_IGNORE_BLACKLIST");
+	return (envVar && *envVar);
+}
+
+
+
+
 float LmmsCore::framesPerTick(sample_rate_t sampleRate)
 {
 	return sampleRate * 60.0f * 4 /

src/core/PluginIssue.cpp

@@ -54,6 +54,8 @@ const char *PluginIssue::msgFor(const PluginIssueType &it)
 			return "required feature not supported";
 		case badPortType:
 			return "unsupported port type";
+		case blacklisted:
+			return "blacklisted plugin";
 		case noIssue:
 			return nullptr;
 	}

src/core/lv2/Lv2Manager.cpp

@@ -26,6 +26,7 @@
 
 #ifdef LMMS_HAVE_LV2
 
+#include <algorithm>
 #include <cstdlib>
 #include <cstring>
 #include <lilv/lilv.h>
@@ -36,6 +37,7 @@
 #include <QElapsedTimer>
 
 #include "ConfigManager.h"
+#include "Engine.h"
 #include "Plugin.h"
 #include "PluginFactory.h"
 #include "Lv2ControlBase.h"
@@ -44,6 +46,16 @@
 
 
 
+const std::set<const char*, Lv2Manager::CmpStr> Lv2Manager::pluginBlacklist =
+{
+	// github.com/calf-studio-gear/calf, #278
+	"http://calf.sourceforge.net/plugins/Analyzer",
+	"http://calf.sourceforge.net/plugins/BassEnhancer"
+};
+
+
+
+
 Lv2Manager::Lv2Manager() :
 	m_uridCache(m_uridMap)
 {
@@ -100,6 +112,7 @@ void Lv2Manager::initPlugins()
 	QElapsedTimer timer;
 	timer.start();
 
+	unsigned blacklisted = 0;
 	LILV_FOREACH(plugins, itr, plugins)
 	{
 		const LilvPlugin* curPlug = lilv_plugins_get(plugins, itr);
@@ -111,6 +124,15 @@ void Lv2Manager::initPlugins()
 		m_lv2InfoMap[lilv_node_as_uri(lilv_plugin_get_uri(curPlug))]
 			= std::move(info);
 		if(issues.empty()) { ++pluginsLoaded; }
+		else
+		{
+			if(std::any_of(issues.begin(), issues.end(),
+				[](const PluginIssue& iss) {
+				return iss.type() == PluginIssueType::blacklisted; }))
+			{
+				++blacklisted;
+			}
+		}
 		++pluginCount;
 	}
 
@@ -133,6 +155,22 @@ void Lv2Manager::initPlugins()
 				"  environment variable \"LMMS_LV2_DEBUG\" to nonempty.";
 		}
 	}
+
+	// TODO: might be better in the LMMS core
+	if(Engine::ignorePluginBlacklist())
+	{
+		qWarning() <<
+			"WARNING! Plugin blacklist disabled! If you want to use the blacklist,\n"
+			"  please set environment variable \"LMMS_IGNORE_BLACKLIST\" to empty or\n"
+			"  do not set it.";
+	}
+	else if(blacklisted > 0)
+	{
+		qDebug() <<
+			"Lv2 Plugins blacklisted:" << blacklisted << "of" << pluginCount << "\n"
+			"  If you want to ignore the blacklist (dangerous!), please set\n"
+			"  environment variable \"LMMS_IGNORE_BLACKLIST\" to nonempty.";
+	}
 }
 
 

src/core/lv2/Lv2Proc.cpp

@@ -65,6 +65,19 @@ Plugin::PluginTypes Lv2Proc::check(const LilvPlugin *plugin,
 	unsigned audioChannels[maxCount] = { 0, 0 }; // audio input and output count
 	unsigned midiChannels[maxCount] = { 0, 0 }; // MIDI input and output count
 
+	const char* pluginUri = lilv_node_as_uri(lilv_plugin_get_uri(plugin));
+	//qDebug() << "Checking plugin" << pluginUri << "...";
+
+	// TODO: manage a global blacklist outside of the code
+	//       for now, this will help
+	//       this is only a fix for the meantime
+	const auto& pluginBlacklist = Lv2Manager::getPluginBlacklist();
+	if (!Engine::ignorePluginBlacklist() &&
+		pluginBlacklist.find(pluginUri) != pluginBlacklist.end())
+	{
+		issues.emplace_back(blacklisted);
+	}
+
 	for (unsigned portNum = 0; portNum < maxPorts; ++portNum)
 	{
 		Lv2Ports::Meta meta;