Fix the MSVC CI fail happening due to outdated vcpkg #7589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rossmaxx
changed the title
Rossmaxx
changed the title
Rossmaxx
changed the title
This reverts commit a95c75e.
messmerd
reviewed
Nov 19, 2024
DomClark
reviewed
Nov 19, 2024
Rossmaxx
changed the title
messmerd
approved these changes
Nov 20, 2024
Contributor
Author
|
Thanks messmerd 😊 |
rubiefawn
pushed a commit
to rubiefawn/lmms
that referenced
this pull request
Nov 28, 2024
* switch to version 1 for msvc-dev-cmd github action * bump msvc build year * try refreshing vcpkg cache msvc * Revert "try refreshing vcpkg cache msvc" This reverts commit e8814f8. * try updating vcpkg manually * Revert "bump msvc build year" This reverts commit a95c75e. * messmerd's review comments * revert the version bump for msvc-dev-cmd * Fix `cd` command --------- Co-authored-by: Dalton Messmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a build fail on our MSVC CI due to outdated version of vcpkg used.
Also bumps the version of the
msvc-dev-cmdgithub action.