Remove obsolete workaround for Qt4 since we no longer use it #7590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakertooth
approved these changes
Nov 19, 2024
Contributor
|
I refrain from merging this for now because our CI is broken and I'll merge as soon as #7589 is taken care of |
Contributor
Author
|
#7589 has been merged |
Member
|
Should we be using |
Contributor
Author
|
If you're waiting for my answer, I have no clue. The code said this was a workaround specifically for Qt4, and since we don't use it anymore, there is no reason to keep it. If I had to guess, this was in place to explicitly state that OS shouldn't steal the menu bar, and now it's probably implicit so it's not like behavior should change, it's just that explicit statement is no longer needed. You could test |
rubiefawn
pushed a commit
to rubiefawn/lmms
that referenced
this pull request
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.