Flagged module as side effect free to enhance tree shaking #313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
sideEffectsflag topackage.jsonto allow the tree shaking feature of webpack to totally disregard this module when imported.A somewhat normal use case of
redux-loggercould be:import { createStore, applyMiddleware } from 'redux'; import thunkMiddleware from 'redux-thunk'; import { createLogger } from './redux-logger'; import Reducer from './Reducer'; let store = createStore(Reducer, applyMiddleware(thunkMiddleware)); if (process.env.NODE_ENV !== 'production') { const loggerMiddleware = createLogger(); store = createStore(Reducer, applyMiddleware(thunkMiddleware, loggerMiddleware)); }When building for
production, current Webpack behavior is to exclude anything inside theprocess.env.NODE_ENV !== 'production'conditional, but not remove theimport { createLogger } from './redux-logger';. Since we are not using the logger in any way, it would be nice to totally disregard it from the production build. Adding the"sideEffects": falseflag topackage.jsonwill achieve exactly that.