Allow webpack to optimize out redux-logger imports #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding `"sideEffects": false` flags to webpack that this package is safe to remove if no functions were imported from it. This means that if I do something along the lines of:
```js
import { createLogger } from 'redux-logger'
/* later */
if (process.env.NODE_ENV === 'development') {
middleware.push(createLogger({ collapsed: true }))
}
```
Then the package will not be included in my bundle when `process.env.NODE_ENV !== 'development'`. Currently, the variable gets removed from local scope, but Webpack cannot optimize the harmony import since it assumes it has side effects, so it remains in bundle.
|
This is literally a duplicate of #313. I swear I checked, honest, but I didn't see that originally. Whoops! Closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
"sideEffects": falseflags to webpack that this package is safe to remove if no functions were imported from it. This means that if I do something along the lines of:Then the package will not be included in my bundle when
process.env.NODE_ENV !== 'development'. Currently, the variable gets removed from local scope, but Webpack cannot optimize the harmony import since it assumes it has side effects, so it remains in bundle.