Swift 3.1 - rebuild all frameworks, clean up all swift warnings #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add the .travis.yml changes as well? |
added 2 commits
March 29, 2017 22:05
1. Change all explicit calls to .debugDescription over to String(describing:). This preserves existing behavior which was happening implicitly before swift 3.1 2. Use CGFloat.pi instead of CGFloat(Double.pi), and fix an issue where I accidentally negated one of the values in an earlier commit
This was referenced Mar 30, 2017
ps2
reviewed
Mar 30, 2017
Loop/Managers/LoopDataManager.swift
Outdated
| updateGroup.enter() | ||
| deviceDataManager.doseStore.getGlucoseEffects(startDate: effectStartDate) { (effects, error) -> Void in | ||
| if let error = error { | ||
| deviceDataManager.doseStore.getGlucoseEffects(start: effectStartDate, end: .distantFuture) { result -> Void in |
There was a problem hiding this comment.
The changes here, in StatusExtensionDataManager, PredictionTableViewController, and StatusTableViewController don't appear to be related to swift 3.1. Could you put those into a different PR along with a description of what they're addressing?
There was a problem hiding this comment.
Swift 3.1 now throws warnings for using these deprecated APIs:
/Users/bharat/local/Loop/Loop/View Controllers/StatusTableViewController.swift:209:38: 'getRecentGlucoseValues(startDate:endDate:resultsHandler:)' is deprecated: Use getGlucoseValues(start:end:completionHandler:) instead
|
Since Swift 3.1 throws warnings for the deprecated APIs, I had rolled those up into this PR. But I can see the value in making those API changes separately so let me pull them out into a separate PR. |
Separate them out from the non-API related warning fixes.
bharat
changed the title
We were accidentally getting 1.2.1 because carthage considers it to be compatible when you use the ~> notation.
bharat
changed the title
ps2
added a commit
that referenced
this pull request
Apr 7, 2017
* refactor of CGM device management * Adding missing files from last cgm refactor pr * Fail if any command in pipeline fails * handling a memory warning and tweaks to the diagnostic report * Fix tests that had been breaking for a while but were hidden by xcpretty swallowing exit code * Show the glucose chart in the widget (#377) Show the glucose chart in the widget. Thanks @bharat! * Swift 3.1 - rebuild all frameworks, clean up all swift warnings (#421) * Rebuild all frameworks with swift 3.1 * Resolve all Swift 3.1 warnings * Swift 3.1 - update LoopKit to 1.2.1 (#423) update LoopKit to 1.2.1 * Swift 3.1 - post widget merge cleanups (#424) * Extend ChartColorPalette in Loop target to add a .default() palette * Update chart appropriately when we remove glucose targets * Drop the first predicted glucose entry. It's the current glucose and its interval to the second is not uniform with the interval for the rest * Use predictedGlucose.startIndex for clarity instead of hardcoding indexes * Swift 3.1 - update dexcom-share-client-swift and G4ShareSpy frameworks (#422) update dexcom-share-client-swift and G4ShareSpy frameworks * Project and margin cleanups (#427) * support share-only cgm source (#426) * fall back to getting cgm data from share if no others are configured * use absence of g5 transmitter to indicate share-only setup. * Widget should always display data using the preferred dispay unit, (#434) regardless of the units used in the StatusExtensionContext. * Break the tie between two visual constraints. (#439) "<NSLayoutConstraint:0x600000097430 LoopUI.ChartContentView:0x7f808c50aae0.height >= 100 (active)>", "<NSLayoutConstraint:0x60000009c2f0 'UISV-hiding' LoopUI.ChartContentView:0x7f808c50aae0.height == 0 (active)>" Lower the priority of the height >= 100 constraint. * bump version (#441)
ps2
pushed a commit
that referenced
this pull request
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves all swift 3.1 warnings.