Widget should always display data using the preferred dispay unit, #434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regardless of the units used in the StatusExtensionContext.
|
Note that I've only tested this in the simulator so far, but that was a useful test case because Loop hardcodes mg/dL predicted glucose values in the simulator. |
|
I'm seeing some other weirdness on my device when I switch units - the chart range doesn't update properly, I'm seeing the historical glucose in one unit and the predicted in another, etc. there's still work to do here. |
ps2
added a commit
that referenced
this pull request
Apr 7, 2017
* refactor of CGM device management * Adding missing files from last cgm refactor pr * Fail if any command in pipeline fails * handling a memory warning and tweaks to the diagnostic report * Fix tests that had been breaking for a while but were hidden by xcpretty swallowing exit code * Show the glucose chart in the widget (#377) Show the glucose chart in the widget. Thanks @bharat! * Swift 3.1 - rebuild all frameworks, clean up all swift warnings (#421) * Rebuild all frameworks with swift 3.1 * Resolve all Swift 3.1 warnings * Swift 3.1 - update LoopKit to 1.2.1 (#423) update LoopKit to 1.2.1 * Swift 3.1 - post widget merge cleanups (#424) * Extend ChartColorPalette in Loop target to add a .default() palette * Update chart appropriately when we remove glucose targets * Drop the first predicted glucose entry. It's the current glucose and its interval to the second is not uniform with the interval for the rest * Use predictedGlucose.startIndex for clarity instead of hardcoding indexes * Swift 3.1 - update dexcom-share-client-swift and G4ShareSpy frameworks (#422) update dexcom-share-client-swift and G4ShareSpy frameworks * Project and margin cleanups (#427) * support share-only cgm source (#426) * fall back to getting cgm data from share if no others are configured * use absence of g5 transmitter to indicate share-only setup. * Widget should always display data using the preferred dispay unit, (#434) regardless of the units used in the StatusExtensionContext. * Break the tie between two visual constraints. (#439) "<NSLayoutConstraint:0x600000097430 LoopUI.ChartContentView:0x7f808c50aae0.height >= 100 (active)>", "<NSLayoutConstraint:0x60000009c2f0 'UISV-hiding' LoopUI.ChartContentView:0x7f808c50aae0.height == 0 (active)>" Lower the priority of the height >= 100 constraint. * bump version (#441)
ps2
pushed a commit
that referenced
this pull request
Aug 17, 2021
* LOOP-1328: Initialize GlucoseStore with whatever CGMManager reports as its healthKitStorageDelay * LOOP-1328: Adds `device` to CachedGlucoseObject * unit tests and WatchHistoricalGlucose * ckpt * pr feedback: remove unneeded change to `GlucoseStoreProtocol` * Revert unintended change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regardless of the units used in the StatusExtensionContext.
This resolves #433