fix how prefix is inserted into output
#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...if the `line` is a multi-line string
Contributor
Author
|
Hrm, now I'm seeing double-prefixes...
|
Owner
|
Ping on the issue of seeing double |
Owner
|
The issue was related to mochajs/mocha#2401. |
Owner
|
So basically after fighting with this a whole bunch, it would seem that our options are either no new lines, or extra ones at random spots due to pauses in piping. Do you have any thoughts on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
linecan be a multiline string. This commit changes how theprefixis inserted to use a multiline regular expression instead of prepending one toline.Fix for the bug reported in #17
This change is