Remove carriage return before each test line in spec reporter. #2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Screenshot of TTY and non-TTY before: Screenshot of TTY and non-TTY after: |
Contributor
Author
|
opening non-TTY output in less before PR: opening non-TTY output in less before PR: |
Munter
force-pushed
the
spec-reporter-carriage-return
branch
from
7eaef45 to
4d4390c
Compare
Member
|
note that Travis-CI ran the full CI suite on SauceLabs from this PR; this only happens if the PR is from anyway, I'm going to merge this manually into v3.0.0. it affects the output and thus could be construed as "breaking". |
Member
|
(appveyor failure is unknown though) |
Member
|
phantom looks ok |
Member
|
merged via 8741506 |
This was referenced Sep 23, 2018
1 task
1 task
This was referenced Dec 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #2400
The spec reporter would output a carriage return char at the beginning of each line in non-TTY's and delete and overwrite the current line in TTY's.
Since this cursor call was only ever used at the beginning of a line it serves no purpose.
See discussion starting at https://gitter.im/mochajs/mocha?at=579a7573ac80b5ea3f149512
TODO: