Conversation
- U# Video 1.0 initial commit
- Fix init order bug with registering callback handlers as well
- I ran into a time where Build & Test hadn't initialized the server time at all so...
- Move UI update to Update from LateUpdate to avoid behaviour crashing when you leave the world because Udon doesn't shut down properly. - Silence warning on a field on USharpVideoPlayer - Make the video player inspector change the default slider value on video players and record prefab modifications correctly
- Also add example prefabs to example scene
- Fix SetLocked API to not toggle locked and actually respect the input locked state - Make SetLocked consistent with SetLooping for how it handles ownership and unify the handling for SetLocked in OnDeserialization - Increase the time between syncs and the sync threshold - Remove default URL and text on URL prefab, change example scene video
- Make ForceSyncVideo seek the video back a bit before syncing to the correct time since the video players can have trouble seeking to exactly the right time if you're already very close to the target time
- I was going to add the japanese for the song (心海), but learned that the sea kanji is bugged due to https://en.wikipedia.org/wiki/Han_unification#Examples_of_language-dependent_glyphs and shows the Chinese version of 海
This was
linked to
issues
Jun 12, 2021
Closed
Closed
- Make sure only the 'privileged' users can lock the video player (aka at the moment the current master and the instance creator). I wasn't sure if I wanted to allow people to take exclusive control over the video player without being master or instance owner, but ended up deciding that it could be too confusing and annoying for others.
This was referenced Jun 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V1 update of USharpVideo using manual sync
Resolves #6 #16 #15 #10 #4
Resolves PR #8, #7 and #2