Skip to content
Open
Show file tree
Hide file tree
Changes from 9 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 41 additions & 0 deletions .github/templates/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
# PR Body Templates

This directory contains templates for onboarding PRs that add the Security Code Scanner to repositories.

## Templates

### `onboarding-pr-body-manual.md`

**Use for:** Manual PRs created by the security team

- More detailed with full language configuration examples
- Includes code snippets for common scenarios
- Comprehensive documentation
- No auto-merge disclaimer

### `onboarding-pr-body-automated.md`

**Use for:** Automated PRs created by workflows

- Shorter, more concise
- Includes auto-merge warning at the top
- Links to README for detailed configuration
- Used by `.github/workflows/onboard-new-repo.yml`

## Variables

Both templates support variable substitution:

- `{{SECURITY_SCANNING_URL}}` - Repository-specific code scanning alerts URL

## Usage

**Manual PRs:**

```bash
# Copy and paste from onboarding-pr-body-manual.md
# Replace {{SECURITY_SCANNING_URL}} with actual URL
```

**Automated workflow:**
The workflow automatically reads `onboarding-pr-body-automated.md` and substitutes variables.
98 changes: 98 additions & 0 deletions .github/templates/onboarding-pr-body-automated.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
## ⚠️ Important Notice - Action Required

**This PR may be auto-merged in the future if not configured.**

If your team does not need the security scanner:

1. **Add a comment on this PR** explaining why your team is opting out
2. **Close this PR** to prevent auto-merge
3. **Add a `.github/no-security-scanner` file** to your repository to prevent future onboarding attempts
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Opt-out file documented but never checked in workflow

The PR body template instructs teams to add a .github/no-security-scanner file to "prevent future onboarding attempts", but the workflow never actually checks for this file before proceeding with onboarding. This means the documented opt-out mechanism doesn't work - repositories that have added the file will still receive onboarding PRs.

Additional Locations (1)

Fix in Cursor Fix in Web


If you need the scanner but want to customize it:

1. Complete the checklist below
2. Review and modify the workflow file as needed
3. Approve and merge this PR when ready

If no action is taken, this PR may be automatically merged after a grace period to ensure baseline security coverage across all repositories.

---

## Required Action

Prior to merging this pull request, please ensure the following has been completed:

- [ ] The lines specifying `branches` correctly specify this repository's default branch (usually `main` or `master`).
- [ ] Any paths you would like to ignore have been added to the `paths-ignored` configuration option (see [setup](https://github.com/MetaMask/action-security-code-scanner/blob/main/README.md#setup))
- [ ] Language configuration has been reviewed - ignore falsely detected languages or add build commands for Java/Kotlin if needed (see Configuration section below)
- [ ] Any existing CodeQL configuration has been disabled.

## What is the Security Code Scanner?

This pull request enables the [MetaMask Security Code Scanner](https://github.com/MetaMask/action-security-code-scanner) GitHub Action. This action runs on each pull request, and will flag potential vulnerabilities as a review comment. It will also scan this repository's default branch, and log any findings in this repository's [Code Scanning Alerts Tab]({{SECURITY_SCANNING_URL}}).

<img width="500" alt="Security Scanner Screenshot" src="https://github.com/user-attachments/assets/41c87b70-79b7-44dd-a444-791b142fbbe1">

The action itself runs various static analysis engines behind the scenes. Currently, it is only running GitHub's CodeQL engine. For this reason, we recommend disabling any existing CodeQL configuration your repository may have.

## How do I interact with the tool?

Every finding raised by the Security Code Scanner will present context behind the potential vulnerability identified, and allow the developer to fix, or dismiss it.

The finding will automatically be dismissed by pushing a commit that fixes the identified issue, or by manually dismissing the alert using the button in GitHub's UI. If dismissing an alert manually, please add any additional context surrounding the reason for dismissal, as this informs our decision to disable, or improve any poor performing rules.

<img width="983" alt="Alert Dismissal Screenshot" src="https://github.com/user-attachments/assets/114219d5-4b4c-4d9d-8bfe-f4666012b73e">

## Configuration

### Language Configuration

The scanner auto-detects languages in your repository. If you need to customize language-specific settings, you can modify the `languages-config` section in the workflow file.

**Common use cases:**

1. **Ignore falsely detected languages:**

```yaml
languages-config: |
[
{
"language": "ruby",
"ignore": true
}
]
```

2. **Configure Java/Kotlin builds:**

```yaml
languages-config: |
[
{
"language": "java-kotlin",
"build_mode": "manual",
"build_command": "./gradlew build",
"version": "21",
"distribution": "temurin"
}
]
```

**Supported languages:** `javascript-typescript`, `python`, `java-kotlin`, `go`, `cpp`, `csharp`, `ruby`

**Build modes:** `none`, `autobuild`, `manual`

### Additional Configuration

For more configuration options, please review the tool's [README](https://github.com/MetaMask/action-security-code-scanner/blob/main/README.md).

Optional secrets that can be configured:

- `SECURITY_SCAN_METRICS_TOKEN` - for metrics collection
- `APPSEC_BOT_SLACK_WEBHOOK` - for Slack notifications

For any additional questions, please reach out to `@app-sec` in Slack.

---

🤖 _This PR was automatically created by the MetaMask Security onboarding system_
51 changes: 51 additions & 0 deletions .github/templates/security-code-scanner.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
name: MetaMask Security Code Scanner

on:
push:
branches:
- { DEFAULT_BRANCH }
pull_request:
branches:
- { DEFAULT_BRANCH }
workflow_call:
secrets:
SECURITY_SCAN_METRICS_TOKEN:
required: false
APPSEC_BOT_SLACK_WEBHOOK:
required: false
workflow_dispatch:

jobs:
security-scan:
uses: MetaMask/action-security-code-scanner/.github/workflows/security-scan.yml@v2
permissions:
actions: read
contents: read
security-events: write
with:
repo: ${{ github.repository }}
scanner-ref: 'v2'
paths-ignored: |
node_modules
**/node_modules/**
**/__snapshots__/**
__snapshots_linux__
**/__stories__/**
.storybook/
**/*.test.ts
**/*.test.tsx
**/*.test.js
**/*.test.jsx
**/*.spec.ts
**/*.spec.tsx
**/*.spec.js
**/*.spec.jsx
**/test*/**
**/e2e/**
**/tests/**
languages-config: |
[
]
secrets:
project-metrics-token: ${{ secrets.SECURITY_SCAN_METRICS_TOKEN }}
slack-webhook: ${{ secrets.APPSEC_BOT_SLACK_WEBHOOK }}
130 changes: 130 additions & 0 deletions .github/workflows/onboard-new-repo.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,130 @@
name: 'Onboard New Repository with SAST'

on:
workflow_dispatch:
inputs:
organization:
description: 'Organization name (e.g., MetaMask)'
required: true
type: string
repository:
description: 'Repository name (e.g., snaps)'
required: true
type: string
repository_dispatch:
types: [new_repository_created]

jobs:
create-sast-pr:
runs-on: ubuntu-latest
permissions:
contents: write
pull-requests: write
steps:
- name: Checkout scanner action repository
uses: actions/checkout@v4
with:
path: scanner-repo

- name: Determine target repository
id: target
run: |
if [ "${{ github.event_name }}" = "repository_dispatch" ]; then
ORG="${{ github.event.client_payload.organization }}"
REPO_NAME="${{ github.event.client_payload.repository }}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Script injection via unsanitized repository_dispatch payload

The workflow directly interpolates github.event.client_payload.organization and github.event.client_payload.repository into shell commands using ${{ }} syntax. Since repository_dispatch payloads can be controlled by external actors (anyone with a token that has write access), a malicious payload containing shell metacharacters like backticks or $() would execute arbitrary commands during workflow runs. This is a documented GitHub Actions script injection vulnerability pattern. Values should be passed via environment variables rather than direct interpolation.

Fix in Cursor Fix in Web

REPO="$ORG/$REPO_NAME"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Unsanitized repository_dispatch payload enables command injection

Values from github.event.client_payload.organization and github.event.client_payload.repository are used directly in shell commands via ${{ }} expression syntax. Since repository_dispatch events can be triggered by external webhooks with arbitrary payloads, a malicious actor could inject shell commands through these fields. The values are used in API calls, git operations, and file paths without any validation or sanitization.

Fix in Cursor Fix in Web

else
REPO="${{ inputs.organization }}/${{ inputs.repository }}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Shell command injection via unsanitized user inputs

The workflow directly interpolates user-controlled values from github.event.client_payload.organization, github.event.client_payload.repository, inputs.organization, and inputs.repository into shell commands using ${{ }} syntax. This is a known GitHub Actions security vulnerability allowing shell command injection. The repository_dispatch event's client_payload can be sent by anyone with repository access, and malicious values like foo; malicious_command would execute arbitrary commands. The safer approach is to pass these values through environment variables.

Fix in Cursor Fix in Web

fi

# Auto-detect default branch from the repository
echo "Detecting default branch for $REPO..."
BASE_BRANCH=$(gh api "repos/$REPO" --jq '.default_branch' 2>/dev/null || echo "")

# If repo is empty or API call failed, default to 'main'
if [ -z "$BASE_BRANCH" ] || [ "$BASE_BRANCH" = "null" ]; then
echo "Repository is empty or default branch not found. Defaulting to 'main'"
BASE_BRANCH="main"
fi

echo "repository=$REPO" >> "$GITHUB_OUTPUT"
echo "base_branch=$BASE_BRANCH" >> "$GITHUB_OUTPUT"
shell: bash
env:
GH_TOKEN: ${{ secrets.ONBOARDING_TOKEN }}

- name: Checkout target repository
uses: actions/checkout@v4
with:
repository: ${{ steps.target.outputs.repository }}
token: ${{ secrets.ONBOARDING_TOKEN }}
path: target-repo
ref: ${{ steps.target.outputs.base_branch }}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Opt-out file check documented but never implemented

The PR body template tells users to add a .github/no-security-scanner file to prevent future onboarding attempts, but the workflow never checks for this file's existence. Repositories that have opted out will still receive onboarding PRs, causing frustration for teams that explicitly declined the scanner.

Additional Locations (1)

Fix in Cursor Fix in Web


- name: Create branch and add SAST workflow
working-directory: target-repo
run: |
git config user.name "MetaMask Security Bot"
git config user.email "[email protected]"

BRANCH_NAME="security/add-sast-scanner"
git checkout -b "$BRANCH_NAME"

# Create .github/workflows directory if it doesn't exist
mkdir -p .github/workflows

# Copy the security scanner workflow template and replace placeholders
BASE_BRANCH="${{ steps.target.outputs.base_branch }}"
sed "s/{ DEFAULT_BRANCH }/$BASE_BRANCH/g" \
../scanner-repo/.github/templates/security-code-scanner.yml \
> .github/workflows/security-code-scanner.yml
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: sed fails when branch name contains forward slashes

The sed command uses / as a delimiter when substituting { DEFAULT_BRANCH } with $BASE_BRANCH. If the default branch name contains a forward slash (e.g., release/main or feature/default), the substitution will fail because the / in the branch name will be interpreted as a sed delimiter. Using a different delimiter like | or # would handle this edge case.

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Sed command breaks on branch names containing slashes

The sed command uses / as the delimiter when replacing { DEFAULT_BRANCH } with $BASE_BRANCH. If the default branch name contains a / character (e.g., release/main or develop/stable), the sed substitution will fail or produce incorrect output because the / in the branch name will be interpreted as a delimiter boundary.

Fix in Cursor Fix in Web


git add .github/workflows/security-code-scanner.yml
git commit -m "chore: add MetaMask Security Code Scanner workflow

This PR adds the MetaMask Security Code Scanner workflow to enable
automated security scanning of the codebase.

The scanner will run on:
- Push to main branch
- Pull requests to main branch
- Manual workflow dispatch

To configure the scanner for your repository's specific needs,
please review the workflow file and adjust as necessary."

git push origin "$BRANCH_NAME"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Documented opt-out mechanism not implemented in workflow

The PR template instructs users to add a .github/no-security-scanner file to "prevent future onboarding attempts", but the workflow never checks for this file's existence before creating the branch and PR. Teams that follow the opt-out instructions will continue receiving unwanted onboarding PRs, breaking the documented contract.

Additional Locations (1)

Fix in Cursor Fix in Web

shell: bash

- name: Create Pull Request
working-directory: target-repo
env:
GH_TOKEN: ${{ secrets.ONBOARDING_TOKEN }}
REPO_NAME: ${{ steps.target.outputs.repository }}
run: |
# Extract owner and repo name for URL construction
OWNER=$(echo "$REPO_NAME" | cut -d'/' -f1)
REPO=$(echo "$REPO_NAME" | cut -d'/' -f2)
BASE_BRANCH="${{ steps.target.outputs.base_branch }}"
SECURITY_URL="https://github.com/${OWNER}/${REPO}/security/code-scanning"

# Read PR body template and substitute variables
PR_BODY=$(cat ../scanner-repo/.github/templates/onboarding-pr-body-automated.md)
PR_BODY="${PR_BODY//\{\{SECURITY_SCANNING_URL\}\}/$SECURITY_URL}"

gh pr create \
--title "🔒 Add MetaMask Security Code Scanner" \
--body "$PR_BODY" \
--base "$BASE_BRANCH" \
--head "security/add-sast-scanner"
shell: bash

- name: Output PR URL
working-directory: target-repo
env:
GH_TOKEN: ${{ secrets.ONBOARDING_TOKEN }}
run: |
PR_URL=$(gh pr view security/add-sast-scanner --json url -q .url)
echo "✅ Pull Request created: $PR_URL"
echo "PR_URL=$PR_URL" >> "$GITHUB_OUTPUT"
shell: bash
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Updated language detector to add Github Actions support by default

### Fixed

- Fix incorrect language selection based on repo config ([#63](https://github.com/MetaMask/action-security-code-scanner/pull/63))

## [2.0.1]

### Fixed
Expand Down
51 changes: 51 additions & 0 deletions examples/security-code-scanner.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
name: MetaMask Security Code Scanner

on:
push:
branches:
- main
pull_request:
branches:
- main
workflow_call:
secrets:
SECURITY_SCAN_METRICS_TOKEN:
required: false
APPSEC_BOT_SLACK_WEBHOOK:
required: false
workflow_dispatch:

jobs:
security-scan:
uses: MetaMask/action-security-code-scanner/.github/workflows/security-scan.yml@v2
permissions:
actions: read
contents: read
security-events: write
with:
repo: ${{ github.repository }}
scanner-ref: 'v2'
paths-ignored: |
node_modules
**/node_modules/**
**/__snapshots__/**
__snapshots_linux__
**/__stories__/**
.storybook/
**/*.test.ts
**/*.test.tsx
**/*.test.js
**/*.test.jsx
**/*.spec.ts
**/*.spec.tsx
**/*.spec.js
**/*.spec.jsx
**/test*/**
**/e2e/**
**/tests/**
languages-config: |
[
]
secrets:
project-metrics-token: ${{ secrets.SECURITY_SCAN_METRICS_TOKEN }}
slack-webhook: ${{ secrets.APPSEC_BOT_SLACK_WEBHOOK }}
Loading