Skip to content

Fix bug introduced to updateChangelog in #158 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MajorLift merged 6 commits into from
Feb 8, 2024
+71 −44
Merged

Fix bug introduced to updateChangelog in #158 #181

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3008846
[update-changelog] Fix bug introduced in #158
MajorLift Dec 11, 2023
8cec96e
[update-changelog] refactor: extract `getNewChangeEntries` method
MajorLift Dec 14, 2023
d18d0fa
Move `git fetch --tags` call to `getMostRecentTag`
MajorLift Feb 8, 2024
aeabb00
Rewrite return statement for readability
MajorLift Feb 8, 2024
da39a58
Replace `Object.keys` with `getKnownPropertyNames`
MajorLift Feb 8, 2024
3aef0c9
Apply suggestion to prefer negation over strict equals check for unde…
MajorLift Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move git fetch --tags call to getMostRecentTag
  • Loading branch information
@MajorLift
MajorLift committed Feb 8, 2024
commit d18d0fa42f288e4e29db1dc2e4e7ed37f0bf4148
5 changes: 3 additions & 2 deletions src/update-changelog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ async function getMostRecentTag({
}: {
tagPrefixes: [string, ...string[]];
}) {
// Ensure we have all tags on remote
await runCommand('git', ['fetch', '--tags']);

let mostRecentTagCommitHash: string | null = null;
for (const tagPrefix of tagPrefixes) {
const revListArgs = [
Expand Down Expand Up @@ -261,8 +264,6 @@ export async function updateChangelog({
packageRename,
});

// Ensure we have all tags on remote
await runCommand('git', ['fetch', '--tags']);
Copy link
Contributor Author

@MajorLift MajorLift Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is moved to getMostRecentTag().

const mostRecentTag = await getMostRecentTag({
tagPrefixes,
});
Expand Down