Skip to content

Fix bug introduced to updateChangelog in #158 #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MajorLift merged 6 commits into from
Feb 8, 2024
Merged

Fix bug introduced to updateChangelog in #158 #181

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3008846
[update-changelog] Fix bug introduced in #158
MajorLift Dec 11, 2023
8cec96e
[update-changelog] refactor: extract `getNewChangeEntries` method
MajorLift Dec 14, 2023
d18d0fa
Move `git fetch --tags` call to `getMostRecentTag`
MajorLift Feb 8, 2024
aeabb00
Rewrite return statement for readability
MajorLift Feb 8, 2024
da39a58
Replace `Object.keys` with `getKnownPropertyNames`
MajorLift Feb 8, 2024
3aef0c9
Apply suggestion to prefer negation over strict equals check for unde…
MajorLift Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace Object.keys with getKnownPropertyNames
  • Loading branch information
@MajorLift
MajorLift committed Feb 8, 2024
commit da39a58a55571cf4e8a03e28096aa12c02c75f77
4 changes: 2 additions & 2 deletions src/update-changelog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { strict as assert } from 'assert';
import execa from 'execa';

import type Changelog from './changelog';
import { Formatter } from './changelog';
import { Formatter, getKnownPropertyNames } from './changelog';
import { ChangeCategory, Version } from './constants';
import { parseChangelog } from './parse-changelog';
import { PackageRename } from './shared-types';
Expand Down Expand Up @@ -290,7 +290,7 @@ export async function updateChangelog({
}

const hasUnreleasedChangesToRelease =
Object.keys(changelog.getUnreleasedChanges()).length > 0;
getKnownPropertyNames(changelog.getUnreleasedChanges()).length > 0;
if (hasUnreleasedChangesToRelease) {
changelog.migrateUnreleasedChangesToRelease(currentVersion);
}
Expand Down