refactor(storage-service): remove itemRemoved events, keep only itemSet

- Remove itemRemoved event publishing from removeItem() and clear()
- Remove StorageServiceItemRemovedEvent type
- Update StorageServiceEvents to only include itemSet
- Simplify API: controllers calling remove/clear already know what they're doing
- Update README and ADR documentation

packages/storage-service/README.md

@@ -47,8 +47,6 @@ StorageService publishes events when data changes, enabling reactive patterns:
 **Events published**:
 - `StorageService:itemSet:{namespace}` - When data is stored
   - Payload: `[value, key]`
-- `StorageService:itemRemoved:{namespace}` - When data is removed
-  - Payload: `[key]`
 
 **Example - Subscribe to changes**:
 ```typescript

packages/storage-service/src/StorageService.ts

@@ -198,14 +198,6 @@ export class StorageService {
   async removeItem(namespace: string, key: string): Promise<void> {
     // Adapter builds full storage key (e.g., mobile: 'storageService:namespace:key')
     await this.#storage.removeItem(namespace, key);
-
-    // Publish event so other controllers can react to removal
-    // Event type: StorageService:itemRemoved:namespace
-    // Payload: [key]
-    this.#messenger.publish(
-      `${SERVICE_NAME}:itemRemoved:${namespace}` as `${typeof SERVICE_NAME}:itemRemoved:${string}`,
-      key,
-    );
   }
 
   /**
@@ -221,7 +213,6 @@ export class StorageService {
 
   /**
    * Clear all data for a namespace.
-   * Delegates to storage adapter which handles clearing.
    *
    * @param namespace - Controller namespace (e.g., 'SnapController').
    */

packages/storage-service/src/index.ts

@@ -17,7 +17,6 @@ export type {
   StorageServiceGetAllKeysAction,
   StorageServiceClearAction,
   StorageServiceItemSetEvent,
-  StorageServiceItemRemovedEvent,
 } from './types';
 
 // Export service name and storage key prefix constants

packages/storage-service/src/types.ts

@@ -183,21 +183,10 @@ export type StorageServiceItemSetEvent = {
   payload: [value: unknown, key: string];
 };
 
-/**
- * Event published when a storage item is removed.
- * Event type includes namespace only, key passed in payload.
- */
-export type StorageServiceItemRemovedEvent = {
-  type: `${typeof SERVICE_NAME}:itemRemoved:${string}`;
-  payload: [key: string];
-};
-
 /**
  * All events that {@link StorageService} publishes.
  */
-export type StorageServiceEvents =
-  | StorageServiceItemSetEvent
-  | StorageServiceItemRemovedEvent;
+export type StorageServiceEvents = StorageServiceItemSetEvent;
 
 /**
  * Actions from other messengers that {@link StorageService} calls.