Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add StorageService for offloading large controller data #7192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: Add StorageService for offloading large controller data #7192
Changes from 1 commit
278eaa9e844fdd19c7d6f5fedbc05af0861de5388ce493d3e81100c2f5c5aec04939f63fe431484adfd57ac8bfc24b150e65efd4160efad12222e57ce68a05afde837ae501a381c9cf8625eee6bda7243d3a7e4e389e50a3aeafacc46e2e21b486708050f209a65054d6fe4595b4faeb363533af5ccb18b5c5d7985579957ccd865a1398165598df9bbd8e39cf634fb6bf384aFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
- getAllKeys and clear now take namespace parameter - Adapters handle filtering and clearing (allows platform-specific optimization) - Removed internal key registry from core (simpler code) - Renamed clearNamespace to clear (consistent with other methods) - Use STORAGE_KEY_PREFIX constant ('storageService:') instead of hardcoded 'storage:' - InMemoryAdapter implements filtering and clearing logic - Mobile adapter can now be optimized per-platform Benefits: - Simpler core service (no registry maintenance) - Platform-specific optimizations possible (IndexedDB can use IDBKeyRange) - Clear adapter responsibilities (filtering, prefix handling) - Consistent API (all methods take namespace first) Tests: 100% coverage maintained, all tests passingUh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Check failure on line 68 in packages/storage-service/src/InMemoryStorageAdapter.test.ts
Check failure on line 132 in packages/storage-service/src/InMemoryStorageAdapter.test.ts
Check failure on line 133 in packages/storage-service/src/InMemoryStorageAdapter.test.ts
Check failure on line 162 in packages/storage-service/src/InMemoryStorageAdapter.test.ts
Check failure on line 31 in packages/storage-service/src/InMemoryStorageAdapter.ts
Check failure on line 96 in packages/storage-service/src/InMemoryStorageAdapter.ts
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.