feat: add override functionality to remote feature flags #7271
+280
−5
fix transaction pay test
- Loading branch information
commit 35b8470e45a56611d2f186f774593616f0b122e0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -178,6 +178,8 @@ describe('Relay Quotes Utils', () => { | |
| getRemoteFeatureFlagControllerStateMock.mockReturnValue({ | ||
|
Contributor
There was a problem hiding this comment. I won't add suggestions for these tests, but the same thing applies as above. |
||
| cacheTimestamp: 0, | ||
| remoteFeatureFlags: {}, | ||
| abTestRawFlags: {}, | ||
| localOverrides: {}, | ||
| }); | ||
|
|
||
| getDelegationTransactionMock.mockResolvedValue(DELEGATION_RESULT_MOCK); | ||
|
|
@@ -553,6 +555,8 @@ describe('Relay Quotes Utils', () => { | |
| relayQuoteUrl, | ||
| }, | ||
| }, | ||
| abTestRawFlags: {}, | ||
| localOverrides: {}, | ||
| }); | ||
|
|
||
| await getRelayQuotes({ | ||
|
|
@@ -913,6 +917,8 @@ describe('Relay Quotes Utils', () => { | |
| relayDisabledGasStationChains: [QUOTE_REQUEST_MOCK.sourceChainId], | ||
| }, | ||
| }, | ||
| abTestRawFlags: {}, | ||
| localOverrides: {}, | ||
| }); | ||
|
|
||
| const result = await getRelayQuotes({ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,8 @@ describe('Feature Flags Utils', () => { | |
| getRemoteFeatureFlagControllerStateMock.mockReturnValue({ | ||
|
Contributor
There was a problem hiding this comment. The same thing applies as above. |
||
| cacheTimestamp: 0, | ||
| remoteFeatureFlags: {}, | ||
| abTestRawFlags: {}, | ||
| localOverrides: {}, | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -56,6 +58,8 @@ describe('Feature Flags Utils', () => { | |
| slippage: SLIPPAGE_MOCK, | ||
| }, | ||
| }, | ||
| abTestRawFlags: {}, | ||
| localOverrides: {}, | ||
| }); | ||
|
|
||
| const featureFlags = getFeatureFlags(messenger); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar as above, it would be better to spread the result of
getDefaultRemoteFeatureFlagControllerState()first: