Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
bec04d7
feat: add override functionality to remote feature flags
asalsys Nov 30, 2025
e78270a
fix lint
asalsys Dec 1, 2025
fe7db8b
fix lint
asalsys Dec 2, 2025
4413b2d
fix lint
asalsys Dec 2, 2025
e07e67c
fix lint
asalsys Dec 2, 2025
ec17188
edit changelog
asalsys Dec 2, 2025
fbdbd14
update pr info on changelog
asalsys Dec 2, 2025
c9cd5aa
fix test
asalsys Dec 2, 2025
4d02e47
fix transaction-controller test
asalsys Dec 2, 2025
e3a4f8f
fix prettier
asalsys Dec 2, 2025
35b8470
fix transaction pay test
asalsys Dec 2, 2025
4201e40
remove get actions
asalsys Dec 4, 2025
7ae47a3
update changelog and fix lint
asalsys Dec 4, 2025
71e4b7a
fix lint
asalsys Dec 8, 2025
ca479c8
fix tests
asalsys Dec 9, 2025
0063bce
update tests
asalsys Dec 9, 2025
9bbf745
update objects in tests
asalsys Dec 9, 2025
414f0f0
Merge branch 'main' into feat/override-functionality-to-remote-featur…
asalsys Dec 9, 2025
f17c947
fix tests
asalsys Dec 9, 2025
4d349ed
update to use the processVersionBasedFlag
asalsys Dec 10, 2025
6a6b98f
spread state
asalsys Dec 11, 2025
7e3500d
fix lint
asalsys Dec 11, 2025
434c892
Merge branch 'main' into feat/override-functionality-to-remote-featur…
asalsys Dec 11, 2025
6c75509
use rawRemoteFeatureFlags instead of processing each flag
asalsys Dec 11, 2025
e562809
fix update Cache
asalsys Dec 11, 2025
a09ceaa
fix lint
asalsys Dec 11, 2025
ffd58e9
update tests
asalsys Dec 11, 2025
c1af969
fix lint
asalsys Dec 11, 2025
9d99264
Update packages/remote-feature-flag-controller/src/remote-feature-fla…
asalsys Dec 12, 2025
1f49998
Update packages/remote-feature-flag-controller/CHANGELOG.md
asalsys Dec 12, 2025
e8f2ff1
Update packages/remote-feature-flag-controller/src/remote-feature-fla…
asalsys Dec 12, 2025
83017de
Update packages/remote-feature-flag-controller/src/remote-feature-fla…
asalsys Dec 12, 2025
6447545
Update packages/remote-feature-flag-controller/src/remote-feature-fla…
asalsys Dec 12, 2025
28a8548
Update packages/remote-feature-flag-controller/src/remote-feature-fla…
asalsys Dec 12, 2025
c3d09e5
Update packages/remote-feature-flag-controller/CHANGELOG.md
asalsys Dec 12, 2025
10c168d
add changes
asalsys Dec 12, 2025
d1357b7
address comments and fix changes
asalsys Dec 12, 2025
fb818a8
fix lint
asalsys Dec 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
asalsys committed Dec 8, 2025
commit fe7db8bf07b82b76e9f00c025eebbb92a78c6579
Original file line number Diff line number Diff line change
Expand Up @@ -1052,9 +1052,14 @@ describe('RemoteFeatureFlagController', () => {
'testFlagForThreshold',
);
expect(groups).toBeDefined();
// Ensure groups is not undefined before accessing array elements
if (!groups) {
throw new Error('Expected groups to be defined');
}
expect(groups).toHaveLength(2); // Expecting 2 groups based on MOCK_FLAGS_WITH_THRESHOLD

// Override with a specific group value
controller.setFlagOverride('testFlagForThreshold', groups![0].value); // groupA value
controller.setFlagOverride('testFlagForThreshold', groups[0].value); // groupA value

expect(controller.getFlag('testFlagForThreshold')).toBe('valueA');
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import type {
FeatureFlagScopeValue,
FeatureFlagScope,
} from './remote-feature-flag-controller-types';
import type { Json } from '@metamask/utils';

import {
generateDeterministicRandomNumber,
isFeatureFlagWithScopeValue,
Expand Down Expand Up @@ -465,7 +465,7 @@ export class RemoteFeatureFlagController extends BaseController<
getAvailableABTestGroups(
flagName: string,
):
| Array<{ name: string; value: Json; scope?: FeatureFlagScope }>
| { name: string; value: Json; scope?: FeatureFlagScope }[]
| undefined {
const rawFlag = this.state.abTestRawFlags[flagName];

Expand Down Expand Up @@ -496,11 +496,11 @@ export class RemoteFeatureFlagController extends BaseController<
*/
getAllABTestFlags(): Record<
string,
Array<{ name: string; value: Json; scope?: FeatureFlagScope }>
{ name: string; value: Json; scope?: FeatureFlagScope }[]
> {
const abTestFlags: Record<
string,
Array<{ name: string; value: Json; scope?: FeatureFlagScope }>
{ name: string; value: Json; scope?: FeatureFlagScope }[]
> = {};

for (const [flagName] of Object.entries(this.state.abTestRawFlags)) {
Expand Down