fix: Disable import-x/no-duplicates in TypeScript files
#427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
force-pushed
the
disable-import-no-duplicates
branch
from
41f5f16 to
d06d2c8
Compare
Member
Author
|
See here as well, where it was disabled in core: https://github.com/MetaMask/core/blob/b0328298a6d06cf698531833c262029eebea09d2/eslint.config.mjs#L118 |
This rule had to be disabled in `core` because the autofixer is very broken. I'm also not sure we want to strictly require one import between type and non-type imports anyway, it's a stylistic preference.
Gudahtt
force-pushed
the
disable-import-no-duplicates
branch
from
d06d2c8 to
ecf06ad
Compare
Member
Author
|
Rebased to resolve changelog conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule had to be disabled in
corebecause the autofixer is very broken. I'm also not sure we want to strictly require one import between type and non-type imports anyway, it's a stylistic preference.Note
Disables
import-x/no-duplicatesin the TypeScript ESLint config, updates the rules snapshot, and notes the change and related autofix issue in the changelog.packages/typescript/src/index.mjs):import-x/no-duplicateswith rationale comments and bug reference.packages/typescript/rules-snapshot.json):import-x/no-duplicates:off.packages/typescript/CHANGELOG.md):import-x/no-duplicates.Written by Cursor Bugbot for commit ecf06ad. This will update automatically on new commits. Configure here.