Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/typescript/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Disable `@typescript-eslint/no-unnecessary-type-arguments` ([#426](https://github.com/MetaMask/eslint-config/pull/426))
- We decided that "unnecessary" type arguments make types easier to read sometimes, so we should allow them.
- Disable `promise/valid-params` because it's redundant in type-checked projects ([#425](https://github.com/MetaMask/eslint-config/pull/425))
- Disable `import-x/no-duplicates` ([#427](https://github.com/MetaMask/eslint-config/pull/427))
- It was a style preference that we may not want, and the auto-fix was broken.

### Fixed

- Prevent non-type imports from being grouped under a type import upon auto-fix ([#427](https://github.com/MetaMask/eslint-config/pull/427))
- This was caused by `import-x/no-duplicates`, which is now disabled.

## [14.1.0]

Expand Down
1 change: 1 addition & 0 deletions packages/typescript/rules-snapshot.json
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@
"getter-return": "off",
"import-x/consistent-type-specifier-style": ["error", "prefer-top-level"],
"import-x/named": "off",
"import-x/no-duplicates": "off",
"import-x/no-unresolved": "off",
"jsdoc/check-access": "error",
"jsdoc/check-alignment": "error",
Expand Down
5 changes: 5 additions & 0 deletions packages/typescript/src/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,11 @@ const config = createConfig({

/* import-x plugin rules */

// This rule is to aggresive about combining type and non-type imports, which I'm not sure that we want.
// But more importantly, the auto-fixer is broken.
// See here for details on that bug: https://github.com/un-ts/eslint-plugin-import-x/issues/231
'import-x/no-duplicates': 'off',

// Handled by TypeScript
'import-x/no-unresolved': 'off',

Expand Down
Loading