Skip to content

INFRA-2867:Fix for input reference for release #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
XxdpavelxX wants to merge 7 commits into
base: main
Choose a base branch
from
Open

INFRA-2867:Fix for input reference for release #105

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
27deee7
INFRA-2867:Fix for input reference for release
XxdpavelxX Aug 21, 2025
df5cc35
Fix attempts PR
XxdpavelxX Aug 21, 2025
0ddf071
Revert "Fix attempts PR"
XxdpavelxX Aug 22, 2025
ca6704a
Update used google sheet
XxdpavelxX Aug 22, 2025
d88cc81
Undo change to spread sheet due to lack of permission
XxdpavelxX Aug 22, 2025
4332e6a
Spread sheet change to clone, non prod sheet
XxdpavelxX Aug 25, 2025
52b5e90
branch issue fix attempt 1
XxdpavelxX Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
INFRA-2867:Fix for input reference for release 
Signed-off-by: Pavel Dvorkin <[email protected]>
  • Loading branch information
@XxdpavelxX
XxdpavelxX committed Aug 21, 2025
commit 27deee7ae4ceb9fa505cda134029bbd8cc38a75a
10 changes: 5 additions & 5 deletions .github/scripts/generate-rc-commits.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const octokit = new Octokit({ auth: githubToken });
async function getTeam(repository, prNumber) {
try {
const { data: prData } = await octokit.pulls.get({
owner: 'MetaMask',
owner: 'consensys-test',
Copy link

@cursor cursor bot Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Inconsistent PR Data and Team Assignments

The script was updated to use consensys-test for fetching PR data and generating PR links, but the teams.json URL still points to MetaMask. This creates an inconsistency where PRs are pulled from a test organization, but team data is sourced from the production MetaMask-planning repo, leading to incorrect team assignments.

Additional Locations (1)

Fix in Cursor Fix in Web

repo: repository,
pull_number: prNumber[1],
});
Expand Down Expand Up @@ -46,7 +46,7 @@ async function getTeam(repository, prNumber) {
// Step 3: Match the PR author's username to a team
const team = teamsJson[author];

// Step 4: Return the team name or 'Unknown' if not found
// Step 4: Return the team name or 'Unknown' if not found.
return team || 'Unknown';

} catch (error) {
Expand All @@ -71,7 +71,7 @@ async function filterCommitsByTeam(platform, branchA, branchB) {
repository = 'metamask-mobile';
break;
case 'extension':
repository = 'metamask-extension';
repository = 'metamask-extension-test-workflow2';
break;
default:
repository = 'metamask-mobile';
Expand Down Expand Up @@ -107,10 +107,10 @@ async function filterCommitsByTeam(platform, branchA, branchB) {
}

// Extract PR number from the commit message using regex
const prMatch = message.match(/\(#(\d{4,5})\)$/u);
const prMatch = message.match(/\(#(\d{1,5})\)$/u);
if (prMatch) {
const prLink = prMatch
? `https://github.com/MetaMask/${repository}/pull/${prMatch[1]}`
? `https://github.com/consensys-test/${repository}/pull/${prMatch[1]}`
: '';
const team = await getTeam(repository, prMatch);

Expand Down
Loading