generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 4
INFRA-2867:Fix for input reference for release #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
XxdpavelxX
wants to merge
7
commits into
main
Choose a base branch
from
INFRA-2867-FixInputReference
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
27deee7
INFRA-2867:Fix for input reference for release
XxdpavelxX df5cc35
Fix attempts PR
XxdpavelxX 0ddf071
Revert "Fix attempts PR"
XxdpavelxX ca6704a
Update used google sheet
XxdpavelxX d88cc81
Undo change to spread sheet due to lack of permission
XxdpavelxX 4332e6a
Spread sheet change to clone, non prod sheet
XxdpavelxX 52b5e90
branch issue fix attempt 1
XxdpavelxX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -306,14 +306,23 @@ create_changelog_pr() { | |
| # Need to run from .github-tools context to inherit it's dependencies/environment | ||
| echo "Current Directory: $(pwd)" | ||
| PROJECT_GIT_DIR=$(pwd) | ||
|
|
||
| # Resolve previous_version when it's a branch name: fetch and use origin/<branch> | ||
| DIFF_BASE="${previous_version}" | ||
| if git ls-remote --heads origin "${previous_version}" | grep -qE "\srefs/heads/${previous_version}$"; then | ||
| echo "Detected remote branch for previous version: ${previous_version}" | ||
| git fetch origin "${previous_version}" | ||
| DIFF_BASE="origin/${previous_version}" | ||
| fi | ||
|
|
||
| cd ./github-tools/ | ||
| ls -ltra | ||
| corepack prepare [email protected] --activate | ||
| # This can't be done from the actions context layer due to the upstream repository having it's own context set with yarn | ||
| yarn --cwd install | ||
|
|
||
| echo "Generating test plan csv.." | ||
| yarn run gen:commits "${platform}" "${previous_version}" "${release_branch_name}" "${PROJECT_GIT_DIR}" | ||
| yarn run gen:commits "${platform}" "${DIFF_BASE}" "${release_branch_name}" "${PROJECT_GIT_DIR}" | ||
|
|
||
| if [[ "${TEST_ONLY:-false}" == 'false' ]]; then | ||
| echo "Updating release sheet.." | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Inconsistent PR Data and Team Assignments
The script was updated to use
consensys-testfor fetching PR data and generating PR links, but theteams.jsonURL still points toMetaMask. This creates an inconsistency where PRs are pulled from a test organization, but team data is sourced from the productionMetaMask-planningrepo, leading to incorrect team assignments.Additional Locations (1)
.github/scripts/generate-rc-commits.mjs#L115-L116