Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: conflicts
  • Loading branch information
georgewrmarshall committed Dec 4, 2025
commit 5bb7a11e15b540082b6936fd3fe3163f51b559d2
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@
"@metamask/eslint-config": "^14.1.0",
"@metamask/eslint-config-jest": "^15.0.0",
"@metamask/eslint-config-nodejs": "^15.0.0",
"@metamask/eslint-config-typescript": "^14.1.0",
"@metamask/eslint-config-typescript": "^15.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer dependency version mismatch between eslint-config packages

The @metamask/eslint-config-typescript package is upgraded to ^15.0.0, which requires @metamask/eslint-config@^15.0.0 as a peer dependency (visible in the yarn.lock at line 3355). However, @metamask/eslint-config remains at ^14.1.0, creating an unsatisfied peer dependency that could cause ESLint configuration issues or warnings during installation.

Additional Locations (1)

Fix in Cursor Fix in Web

"@metamask/utils": "^11.8.1",
"@types/eslint-plugin-tailwindcss": "^3",
"@types/jest": "^27.4.1",
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3346,20 +3346,20 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eslint-config-typescript@npm:^14.1.0":
version: 14.1.0
resolution: "@metamask/eslint-config-typescript@npm:14.1.0"
"@metamask/eslint-config-typescript@npm:^15.0.0":
version: 15.0.0
resolution: "@metamask/eslint-config-typescript@npm:15.0.0"
dependencies:
"@eslint/js": "npm:^9.11.0"
peerDependencies:
"@metamask/eslint-config": ^14.1.0
"@metamask/eslint-config": ^15.0.0
eslint: ^9.11.0
eslint-import-resolver-typescript: ^3.6.3
eslint-plugin-import-x: ^4.3.0
eslint-plugin-jsdoc: ^50.2.4
typescript: ">=4.8.4 <5.9.0"
typescript-eslint: ^8.24
checksum: 10/697b61648969f5f53179b8cf83ffb1aa1dbe5ce9ad4f7f4ed0bc4e436c510f1d28543e764467fd880ccb2579b5810e78eee63f972daa55f1b599844b53ea13ca
typescript: ">=4.8.4 <6"
typescript-eslint: ^8.39.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: typescript-eslint version too low for peer dependency

The new @metamask/[email protected] requires typescript-eslint@^8.39.0 as a peer dependency, but the project has typescript-eslint@^8.7.0 installed. Version 8.7.0 does not satisfy the ^8.39.0 requirement, which could cause ESLint configuration failures or unexpected behavior.

Fix in Cursor Fix in Web

checksum: 10/5ff44e8970a67f87da92a65b8478d22374713ca94feb671ba462b87441ae8b47e427857b363b79b50e6078856c0f482c3965de7f2ee38fe0b40f8f4e27891540
languageName: node
linkType: hard

Expand Down Expand Up @@ -3404,7 +3404,7 @@ __metadata:
"@metamask/eslint-config": "npm:^14.1.0"
"@metamask/eslint-config-jest": "npm:^15.0.0"
"@metamask/eslint-config-nodejs": "npm:^15.0.0"
"@metamask/eslint-config-typescript": "npm:^14.1.0"
"@metamask/eslint-config-typescript": "npm:^15.0.0"
"@metamask/utils": "npm:^11.8.1"
"@types/eslint-plugin-tailwindcss": "npm:^3"
"@types/jest": "npm:^27.4.1"
Expand Down