chore(deps-dev): bump @metamask/eslint-config-typescript from 14.1.0 to 15.0.0 #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
Contributor
📖 Storybook Preview |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| "@metamask/eslint-config-jest": "^14.1.0", | ||
| "@metamask/eslint-config-nodejs": "^14.0.0", | ||
| "@metamask/eslint-config-typescript": "^14.1.0", | ||
| "@metamask/eslint-config-typescript": "^15.0.0", |
There was a problem hiding this comment.
Bug: Peer dependency version mismatch between eslint-config packages
The @metamask/eslint-config-typescript package is upgraded to ^15.0.0, which requires @metamask/eslint-config@^15.0.0 as a peer dependency (visible in the yarn.lock at line 3355). However, @metamask/eslint-config remains at ^14.1.0, creating an unsatisfied peer dependency that could cause ESLint configuration issues or warnings during installation.
Additional Locations (1)
| typescript-eslint: ^8.24 | ||
| checksum: 10/697b61648969f5f53179b8cf83ffb1aa1dbe5ce9ad4f7f4ed0bc4e436c510f1d28543e764467fd880ccb2579b5810e78eee63f972daa55f1b599844b53ea13ca | ||
| typescript: ">=4.8.4 <6" | ||
| typescript-eslint: ^8.39.0 |
There was a problem hiding this comment.
Bug: typescript-eslint version too low for peer dependency
The new @metamask/[email protected] requires typescript-eslint@^8.39.0 as a peer dependency, but the project has typescript-eslint@^8.7.0 installed. Version 8.7.0 does not satisfy the ^8.39.0 requirement, which could cause ESLint configuration failures or unexpected behavior.
Contributor
📖 Storybook Preview |
There was a problem hiding this comment.
Bug: Peer dependency version mismatch for typescript-eslint
The upgraded @metamask/[email protected] requires typescript-eslint: ^8.39.0 as a peer dependency, but package.json specifies typescript-eslint: ^8.7.0. While npm/yarn may resolve to a higher version, the current constraint allows installing versions below 8.39.0 which may not be compatible with the new config.
package.json#L127-L128
metamask-design-system/package.json
Lines 127 to 128 in f4e2f72
package.json#L90-L91
metamask-design-system/package.json
Lines 90 to 91 in f4e2f72
georgewrmarshall
previously approved these changes
Dec 4, 2025
Contributor
📖 Storybook Preview |
Bumps [@metamask/eslint-config-typescript](https://github.com/MetaMask/eslint-config) from 14.1.0 to 15.0.0. - [Release notes](https://github.com/MetaMask/eslint-config/releases) - [Commits](https://github.com/MetaMask/eslint-config/compare/@metamask/[email protected]...@metamask/[email protected]) --- updated-dependencies: - dependency-name: "@metamask/eslint-config-typescript" dependency-version: 15.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
georgewrmarshall
force-pushed
the
dependabot/npm_and_yarn/metamask/eslint-config-typescript-15.0.0
branch
from
d2e0986 to
f48b3ef
Compare
Contributor
📖 Storybook Preview |
georgewrmarshall
approved these changes
Dec 4, 2025
brianacnguyen
approved these changes
Dec 4, 2025
georgewrmarshall
deleted the
dependabot/npm_and_yarn/metamask/eslint-config-typescript-15.0.0
branch
brianacnguyen
pushed a commit
that referenced
this pull request
Dec 9, 2025
## **Description** This PR releases version 17.0.0 of the MetaMask Design System, featuring important fixes for mobile font compatibility, the addition of the ButtonHero component to React, export fixes for React Native, and various dependency updates including ESLint configuration upgrades. ## **Included PRs** #836, #837, #838, #840, #843, #845, #846, #847, #848, #850, #851, #852, #853, #854, #855, #856, #857, #858, #859, #861, #862, #863, #864 ## **Manual testing steps** 1. Check package.json version bumps align with included changes 2. Check changelog accurately reflects the release ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release 17.0.0 introducing React `ButtonHero`, RN font naming changes and TWRNC preset font family rename (both breaking), plus RN export fix and dependency updates. > > - **Release 17.0.0** > - Bump root `package.json` to `17.0.0`. > - **React (`@metamask/[email protected]`)** > - Add `ButtonHero` component for prominent CTAs. > - Update `@metamask/utils` peer to `^11.8.1`. > - **React Native (`@metamask/[email protected]`)** > - BREAKING: Rename font files to hyphenated PostScript format for iOS Metro compatibility. > - Export missing `TextButtonSize` enum. > - Peer: require `@metamask/design-system-twrnc-preset@^0.3.0`; update `@metamask/utils` peer. > - **TWRNC preset (`@metamask/[email protected]`)** > - BREAKING: Rename font family names to hyphenated PostScript format for iOS/expo-font. > - **Changelogs** > - Update `CHANGELOG.md` links and entries for all packages. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9a90311. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps @metamask/eslint-config-typescript from 14.1.0 to 15.0.0.
Release notes
Sourced from
@metamask/eslint-config-typescript's releases.... (truncated)
Commits
0b8cf6dRelease/15.0.0 (#431)9568eb3fix: Disablejsdoc/check-indentationto fix bullet list formatting (#430)7837174feat: Loosen@typescript-eslint/naming-conventionfor object literal proper...cf93ef1fix: Disableimport-x/no-duplicatesin TypeScript files (#427)f3246f7chore: Disable redudant lint rule (#425)383fbecfeat: Disable@typescript-eslint/no-unnecessary-type-arguments(#426)a0e0bc8feat: Convert all warnings to errors (#424)b243e90chore: Increase minimumtypescript-eslintversion (#423)b116974Allow remaining TypeScript 5.x versions (#422)c70a3ffBREAKING: Updatejsdoc/require-jsdocto require documentation for more thin...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Note
Upgrade @metamask/eslint-config-typescript to 15.0.0 and adjust Jazzicon React Native imports to separate type/value.
@metamask/eslint-config-typescriptfrom^14.1.0to^15.0.0inpackage.json; update related entries inyarn.lock.packages/design-system-react-native/src/components/temp-components/Jazzicon/Jazzicon.tsx, split React Native imports to separate type (type { ViewStyle }) from value ({ View }).Written by Cursor Bugbot for commit f48b3ef. This will update automatically on new commits. Configure here.