chore: remove unused eslint-disable comments after eslint upgrades #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
📖 Storybook Preview |
amandaye0h
approved these changes
Dec 4, 2025
Contributor
📖 Storybook Preview |
brianacnguyen
pushed a commit
that referenced
this pull request
Dec 9, 2025
## **Description** This PR releases version 17.0.0 of the MetaMask Design System, featuring important fixes for mobile font compatibility, the addition of the ButtonHero component to React, export fixes for React Native, and various dependency updates including ESLint configuration upgrades. ## **Included PRs** #836, #837, #838, #840, #843, #845, #846, #847, #848, #850, #851, #852, #853, #854, #855, #856, #857, #858, #859, #861, #862, #863, #864 ## **Manual testing steps** 1. Check package.json version bumps align with included changes 2. Check changelog accurately reflects the release ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Release 17.0.0 introducing React `ButtonHero`, RN font naming changes and TWRNC preset font family rename (both breaking), plus RN export fix and dependency updates. > > - **Release 17.0.0** > - Bump root `package.json` to `17.0.0`. > - **React (`@metamask/[email protected]`)** > - Add `ButtonHero` component for prominent CTAs. > - Update `@metamask/utils` peer to `^11.8.1`. > - **React Native (`@metamask/[email protected]`)** > - BREAKING: Rename font files to hyphenated PostScript format for iOS Metro compatibility. > - Export missing `TextButtonSize` enum. > - Peer: require `@metamask/design-system-twrnc-preset@^0.3.0`; update `@metamask/utils` peer. > - **TWRNC preset (`@metamask/[email protected]`)** > - BREAKING: Rename font family names to hyphenated PostScript format for iOS/expo-font. > - **Changelogs** > - Update `CHANGELOG.md` links and entries for all packages. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 9a90311. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After recent Dependabot upgrades to
@metamask/eslint-config-jest(14.1.0 → 15.0.0) and@metamask/auto-changelog(5.2.0 → 5.3.0), several eslint-disable comments became unnecessary. This PR removes those unused disable comments to clean up the codebase.The changes include:
@typescript-eslint/naming-conventiondisable comments in global.d.ts filesjest/no-conditional-in-testdisable comments that are no longer needed@typescript-eslint/no-unsafe-enum-comparisondisable comments in switch statementsThese changes were made by running
yarn lint:fixafter the eslint configuration upgrades.Related issues
Fixes: N/A (cleanup after automated dependency upgrades)
Manual testing steps
yarn installyarn lintto verify no linting errorsyarn testto ensure all tests passScreenshots/Recordings
N/A - This is a code cleanup change with no visual impact.
Before
Eslint warnings about unused disable comments
After
Running
yarn lint:fixreturns no eslint warningslint.fix.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Removes obsolete eslint-disable comments (e.g., jest/no-conditional-in-test, @typescript-eslint/no-unsafe-enum-comparison, naming-convention) across test files and d.ts declarations with no functional changes.
eslint-disablecomments across multiple packages/tests.packages/design-system-react-native/global.d.ts,packages/design-system-react/global.d.ts: drop@typescript-eslint/naming-conventiondisables in*.svgmodule declarations.packages/design-system-react/scripts/create-component/create-component.test.ts: removejest/no-conditional-in-testdisables infs.readFilemocks.packages/design-system-react/src/components/Icon/template.test.ts: keep only@typescript-eslint/no-base-to-stringdisable; removejest/no-conditional-in-testfrom comment.packages/design-system-tailwind-preset/src/{colors,index,typography}.test.ts: removejest/no-conditional-in-testdisables from filtering/theme mocks.scripts/create-package/utils.test.ts: removejest/no-conditional-in-testand@typescript-eslint/no-unsafe-enum-comparisondisables in switch cases.scripts/create-package/utils.ts: remove@typescript-eslint/no-unsafe-enum-comparisondisables inprocessTemplateContentswitch.Written by Cursor Bugbot for commit 1c2726d. This will update automatically on new commits. Configure here.