fix: update address qr code navigation to prevent infinite loop of navigation #34381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
team-accounts-framework
hmalik88
added
the
no-changelog
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +5 -11)
|
Collaborator
Builds ready [8edef27]
UI Startup Metrics (1274 ± 86 ms)
Benchmark value 1088 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1080 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 874 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 42 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 947 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2322 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1835 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1829 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 13 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1824 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2540 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2087 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2074 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 59 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 35 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2069 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1595 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1364 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1363 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 121 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1339 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 13 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1938 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1519 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1519 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 335 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 64 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 64 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 17 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1489 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 48 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1764 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1486 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1485 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1461 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 19 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2167 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1848 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1847 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 321 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 81 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 16 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1816 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 118 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1913ms | Sum of p95 exceeds: 2254.8ms Sum of all benchmark exceeds: 4167.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
Builds ready [6a85988]
UI Startup Metrics (1299 ± 67 ms)
Benchmark value 1115 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1106 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 217 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 897 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1416 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1210 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1193 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 12 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 983 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2347 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1847 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1840 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 23 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 41 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1833 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2531 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2111 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2107 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 72 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 270 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 33 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2105 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1432 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1240 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1758 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 290 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 61 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1727 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1458 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1458 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 16 exceeds gate value 15 for firefox webpack home mean getState Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1434 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 17 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2168 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1749 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1749 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 300 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 73 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 17 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1703 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 45 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1414ms | Sum of p95 exceeds: 1912.8ms Sum of all benchmark exceeds: 3326.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
montelaidev
approved these changes
Jul 18, 2025
PatrykLucka
approved these changes
Jul 18, 2025
metamaskbot
added
the
release-13.1.0
gantunesr
pushed a commit
that referenced
this pull request
Jul 28, 2025
…vigation (#34381) ## **Description** Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? The `AddressQRCode` component currently uses a `history.push` call to navigate to its respective account details page. This is erroneous because account details uses `history.goBack` which just picks the page it came from which is `AddressQRCode`. 2. What is the improvement/solution? Use `history.goBack` in the `AddressQRCode` component. ## **Manual testing steps** 1. Build from this branch. 2. Navigate to an account's address qr code page, navigate back to the account details page, hit back again. 3. Observe that the navigation leads you back to the home page. ## **Screenshots/Recordings** ### **Before** https://github.com/user-attachments/assets/e238f5fc-4dc4-4901-b137-984b06d85130 ### **After** https://github.com/user-attachments/assets/da2e140e-9455-4612-93ef-66ec730e4dc1 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
7 tasks
DDDDDanica
pushed a commit
that referenced
this pull request
Jul 29, 2025
…vigation cherry-pick cp-13.0.0 (#34679) ## **Description** Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? The `AddressQRCode` component currently uses a `history.push` call to navigate to its respective account details page. This is erroneous because account details uses `history.goBack` which just picks the page it came from which is `AddressQRCode`. 2. What is the improvement/solution? Use `history.goBack` in the `AddressQRCode` component. Cherry-pick from: #34381 Fixes: #34607 ## **Manual testing steps** 1. Build from this branch. 2. Navigate to an account's address qr code page, navigate back to the account details page, hit back again. 3. Observe that the navigation leads you back to the home page. ## **Screenshots/Recordings** ### **Before** https://github.com/user-attachments/assets/e238f5fc-4dc4-4901-b137-984b06d85130 ### **After** https://github.com/user-attachments/assets/da2e140e-9455-4612-93ef-66ec730e4dc1 ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Co-authored-by: Hassan Malik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions:
AddressQRCodecomponent currently uses ahistory.pushcall to navigate to its respective account details page. This is erroneous because account details useshistory.goBackwhich just picks the page it came from which isAddressQRCode.history.goBackin theAddressQRCodecomponent.Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-07-17.at.4.13.13.PM.mov
After
Screen.Recording.2025-07-17.at.4.23.26.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist