Skip to content

fix: update address qr code navigation to prevent infinite loop of navigation #34381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hmalik88 merged 5 commits into from
Jul 18, 2025
Merged

fix: update address qr code navigation to prevent infinite loop of navigation #34381

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
760377d
fix: change navigation to history.goBack to prevent infinite loop of …
hmalik88 Jul 17, 2025
4b45a60
test: update address qr code test
hmalik88 Jul 17, 2025
8edef27
Merge branch 'main' into hm/mul-442
hmalik88 Jul 17, 2025
d940193
Merge branch 'main' into hm/mul-442
hmalik88 Jul 17, 2025
6a85988
fix: remove unused vars
hmalik88 Jul 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: remove unused vars
  • Loading branch information
@hmalik88
hmalik88 committed Jul 17, 2025
commit 6a859887b437bd95ab92ee60a57971193cfedefd
5 changes: 1 addition & 4 deletions ui/pages/multichain-accounts/address-qr-code/address-qr-code.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ import { Provider } from 'react-redux';
import { MemoryRouter, Route } from 'react-router-dom';
import configureStore from 'redux-mock-store';
import thunk from 'redux-thunk';
import {
ACCOUNT_DETAILS_ROUTE,
ACCOUNT_DETAILS_QR_CODE_ROUTE,
} from '../../../helpers/constants/routes';
import { ACCOUNT_DETAILS_QR_CODE_ROUTE } from '../../../helpers/constants/routes';
import { openBlockExplorer } from '../../../components/multichain/menu-items/view-explorer-menu-item';
import { getMultichainAccountUrl } from '../../../helpers/utils/multichain/blockExplorer';
import { useMultichainSelector } from '../../../hooks/useMultichainSelector';
Expand Down
1 change: 0 additions & 1 deletion ui/pages/multichain-accounts/address-qr-code/address-qr-code.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
ButtonSecondarySize,
IconName,
} from '../../../components/component-library';
import { ACCOUNT_DETAILS_ROUTE } from '../../../helpers/constants/routes';
import {
BackgroundColor,
TextVariant,
Expand Down
Loading