chore: Add buttons to test error capture #34386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Builds ready [765440f]
UI Startup Metrics (1248 ± 67 ms)
Benchmark value 1249 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1069 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 213 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 865 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 17 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2551 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2053 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 2041 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 47 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 10 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2036 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2807 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2268 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2261 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 69 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 254 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 37 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2259 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1600 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1367 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1367 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 116 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1342 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 18 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1889 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1519 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1519 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 304 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 62 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 59 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1496 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 109 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1794 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1499 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1499 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 102 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 11 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1474 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 24 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2146 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1799 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1798 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 305 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 77 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 64 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 38 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1759 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 179 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2825ms | Sum of p95 exceeds: 3111.8ms Sum of all benchmark exceeds: 5936.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
force-pushed
the
add-capture-error-dev-buttons
branch
from
765440f to
4a85fcd
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Collaborator
Builds ready [4a85fcd]
UI Startup Metrics (1269 ± 59 ms)
Benchmark value 1270 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1089 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1082 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 878 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1367 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1181 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 228 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 974 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2568 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2078 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 2069 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 23 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2062 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2792 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2412 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2401 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 74 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 195 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 379 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 40 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2389 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1454 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1257 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1257 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 29 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1232 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1719 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 285 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 37 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 15 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 35 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1745 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1486 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1485 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1463 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2164 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1833 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1833 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 350 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1792 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 2371ms | Sum of p95 exceeds: 3108.8ms Sum of all benchmark exceeds: 5479.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Gudahtt
commented
Jul 17, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This was referenced Jul 17, 2025
Collaborator
Builds ready [d618348]
UI Startup Metrics (1248 ± 69 ms)
Benchmark value 1075 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1068 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 210 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 865 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 224 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2373 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1878 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1871 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 45 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1867 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2517 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2132 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2124 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 268 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 30 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2115 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1545 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1314 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1314 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 120 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 28 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 18 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1291 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1867 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 343 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 156 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 29 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 96 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1785 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1498 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1497 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 10 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1474 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 14 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2274 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1802 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1802 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 321 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 54 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 35 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 31 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1767 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 37 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1887ms | Sum of p95 exceeds: 2434.8ms Sum of all benchmark exceeds: 4321.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
| * @deprecated This is only mean to facilitiate E2E testing. We should not | ||
| * use this for handling errors. | ||
| */ | ||
| captureTestError(message) { |
Contributor
There was a problem hiding this comment.
should these test only functions only be shipped when process.env.IN_TEST is "true"?
Member
Author
There was a problem hiding this comment.
They're also used for manual testing, like the other pre-existing ones are. I used them in a yarn dist build to discover this issue.
That makes the comment block inaccurate though. I just copied it from the other functions which are used for the exact same purpose. I can fix the comment in a follow-up PR perhaps.
Gudahtt
force-pushed
the
add-capture-error-dev-buttons
branch
from
d618348 to
5f4a90b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
7 tasks
Collaborator
|
❌ test-e2e-chrome-api-specs failed. View the html report here. |
Collaborator
Builds ready [5f4a90b]
UI Startup Metrics (1260 ± 58 ms)
Benchmark value 1080 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1074 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 212 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 869 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 225 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 19 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 951 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 19 exceeds gate value 17 for chrome browserify home p95 setupStore Benchmark value 2514 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2026 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 2017 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 43 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2008 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2714 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2283 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2262 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 67 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 236 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 37 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2260 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1508 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1304 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1304 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 122 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1282 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1819 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 1519 exceeds gate value 1495 for firefox browserify home p95 load Benchmark value 1517 exceeds gate value 1495 for firefox browserify home p95 domContentLoaded Benchmark value 366 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 60 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 42 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 38 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1486 exceeds gate value 1475 for firefox browserify home p95 loadScripts Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1470 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1470 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1446 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2119 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1713 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1713 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 217 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 77 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1696 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 33 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2278ms | Sum of p95 exceeds: 2405.8ms Sum of all benchmark exceeds: 4683.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Member
Author
This is fine though, these buttons are used to test errors. Better to fail noisily than silently if we're in an environment where the test won't work. We could improve this by using the new |
Collaborator
Builds ready [87a7d12]
UI Startup Metrics (1612 ± 96 ms)
Benchmark value 1613 exceeds gate value 1234 for chrome browserify home mean uiStartup Benchmark value 1370 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1354 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 25 exceeds gate value 20 for chrome browserify home mean domInteractive Benchmark value 920 exceeds gate value 800 for chrome browserify home mean firstPaint Benchmark value 278 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 30 exceeds gate value 23 for chrome browserify home mean firstReactRender Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 1091 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1805 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1539 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1528 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 54 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 1530 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 312 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 56 exceeds gate value 45 for chrome browserify home p95 firstReactRender Benchmark value 22 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 1263 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 3841 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 3027 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 3012 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 37 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 277 exceeds gate value 199 for chrome webpack home mean firstPaint Benchmark value 106 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 12 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 3005 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 5450 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 4181 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 4171 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 101 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 593 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 241 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 630 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 38 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 4165 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1458 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1265 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1265 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 12 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1244 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1741 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 276 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 58 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1799 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1496 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1496 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 15 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1471 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 29 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2221 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1838 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1837 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 302 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 70 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 37 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 41 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1794 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 248 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 8082ms | Sum of p95 exceeds: 13871.8ms Sum of all benchmark exceeds: 21953.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Add two buttons to the "Developer Options" settings page to test that captured Sentry errors work correctly (one button for the UI, one for the background). We have two similar buttons already for unhandled errors, but not for explicitly handled errors. These will assist with manual testing for this bug: #34371
Gudahtt
force-pushed
the
add-capture-error-dev-buttons
branch
from
87a7d12 to
9091454
Compare
DDDDDanica
approved these changes
Jul 21, 2025
Contributor
|
LGTM ! |
Collaborator
Builds ready [9091454]
UI Startup Metrics (1289 ± 62 ms)
Benchmark value 1104 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1097 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 889 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1418 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1205 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1200 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 43 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 233 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 990 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2373 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1882 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1871 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 44 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 13 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1866 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2547 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2168 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2161 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 282 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 32 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2154 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 176 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1543 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1315 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1315 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 114 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 30 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 29 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 16 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1291 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1980 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 294 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 56 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 33 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 20 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 92 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1740 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1469 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1469 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 30 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1447 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 17 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2119 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1769 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1769 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 281 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 65 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 66 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 22 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1737 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 40 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1891ms | Sum of p95 exceeds: 2479.8ms Sum of all benchmark exceeds: 4370.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
davidmurdoch
approved these changes
Jul 21, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
metamaskbot
added
the
release-13.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add two buttons to the "Developer Options" settings page to test that captured Sentry errors work correctly (one button for the UI, one for the background).
We have two similar buttons already for unhandled errors, but not for explicitly handled errors.
Changelog
CHANGELOG entry: null
Related issues
These will assist with manual testing for this bug: #34371
Manual testing steps
.metamaskrc:SENTRY_DSNandSENTRY_DSN_DEVset to your personal Sentry DSN (see these docs for help setting that up)ENABLE_SETTINGS_PAGE_DEV_OPTIONSset totrueScreenshots/Recordings
Before
N/A
After
Screen.Recording.2025-07-17.at.20.28.45.mov
Pre-merge author checklist
Pre-merge reviewer checklist