chore: Improve accuracy of test error inline comments #34404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Member
Author
|
This depends upon #34386 |
Collaborator
Builds ready [101a090]
UI Startup Metrics (1259 ± 52 ms)
Benchmark value 1079 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1072 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 211 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 867 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 229 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2325 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1831 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1822 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 11 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1816 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2507 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2045 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2041 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 63 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 215 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 32 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2039 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1495 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1272 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1272 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 111 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 33 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 15 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 7 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1249 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 16 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1767 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 300 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 135 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 19 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 66 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1728 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1462 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1462 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 104 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 28 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 8 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1439 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2199 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1849 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1848 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 319 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 51 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 33 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1806 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 40 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1360ms | Sum of p95 exceeds: 1957.8ms Sum of all benchmark exceeds: 3317.8ms |
Gudahtt
force-pushed
the
add-capture-error-dev-buttons
branch
from
87a7d12 to
9091454
Compare
Gudahtt
force-pushed
the
fix-throw-error-inline-docs
branch
from
101a090 to
b95f31f
Compare
Collaborator
Builds ready [b95f31f]
UI Startup Metrics (1286 ± 61 ms)
Benchmark value 1103 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1096 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 215 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 887 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1376 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 44 exceeds gate value 41 for chrome browserify home p95 domInteractive Benchmark value 232 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 14 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 959 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2450 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1937 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1924 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 50 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1919 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2834 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2325 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2243 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 61 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 354 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 276 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2231 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1502 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1302 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1302 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 117 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 28 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 13 exceeds gate value 11 for firefox browserify home mean getState Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1280 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 10 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1779 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 342 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 56 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 18 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 42 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1741 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1483 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1483 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 107 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1459 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 2103 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1822 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1822 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 322 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 18 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1782 exceeds gate value 1630 for firefox webpack home p95 loadScripts Sum of mean exceeds: 2067ms | Sum of p95 exceeds: 2786.8ms Sum of all benchmark exceeds: 4853.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
MajorLift
previously approved these changes
Jul 28, 2025
Gudahtt
force-pushed
the
fix-throw-error-inline-docs
branch
from
1f5502b to
0a456b2
Compare
MajorLift
approved these changes
Jul 28, 2025
Collaborator
Builds ready [0a456b2]
UI Startup Metrics (1304 ± 58 ms)
Benchmark value 1128 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1119 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 256 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 872 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1391 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1200 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1192 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 279 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 36 exceeds gate value 33 for chrome browserify home p95 getState Benchmark value 18 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 953 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2385 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1881 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1870 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 22 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 67 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1861 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2723 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2157 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2150 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 290 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 20 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2128 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 183 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1463 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1271 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1270 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 112 exceeds gate value 110 for firefox browserify home mean domInteractive Benchmark value 30 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1249 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 1722 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 289 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 59 exceeds gate value 55 for firefox browserify home p95 firstReactRender Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1783 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1521 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1520 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 109 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 29 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1498 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 17 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2108 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1823 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1822 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 325 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 21 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1797 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 49 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1971ms | Sum of p95 exceeds: 2443.8ms Sum of all benchmark exceeds: 4414.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
The inline comments on functions relating to "test errors" have been updated to clarify that they're used in both manual and E2E testing, not just E2E testing. This better explains why they're not enabled only in test builds.
Co-authored-by: Jongsun Suh <[email protected]>
Gudahtt
force-pushed
the
fix-throw-error-inline-docs
branch
from
0a456b2 to
93873e6
Compare
Collaborator
Builds ready [93873e6]
UI Startup Metrics (1175 ± 78 ms)
Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 236 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 11 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2526 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 65 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 391 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 271 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 10 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 11 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 219 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 14 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 33 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1655 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 37 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 55 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1987 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 253 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 92 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 65 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 57 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 12 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 298ms | Sum of p95 exceeds: 691.8ms Sum of all benchmark exceeds: 989.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-project-automation
bot
moved this from Needs dev review
to Review finalised - Ready to be merged
in PR review queue
DDDDDanica
approved these changes
Aug 5, 2025
Contributor
|
LGTM ! |
github-project-automation
bot
moved this from Review finalised - Ready to be merged
to Merged, Closed or Archived
in PR review queue
metamaskbot
added
the
release-13.2.0
Collaborator
|
No release label on PR. Adding release label release-13.2.0 on PR, as PR was added to branch 13.2.0 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The inline comments on functions relating to "test errors" have been updated to clarify that they're used in both manual and E2E testing, not just E2E testing. This better explains why they're not enabled only in test builds.
Changelog
CHANGELOG entry: null
Related issues
Fixes a problem that was expanded and commented upon in #34386
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist