Skip to content

Conversation

@gantunesr
Copy link
Member

@gantunesr gantunesr commented Jul 25, 2025

Description

This PR solves 2 issues,

  1. Navigation between the screens of wallet details, account details, and QR code. The account details must return to the wallet screen regardless of the wallet details screen to avoid infinite navigation loops.
  2. The ShowHideToggle in the import SRP screen was glued to the input box, this adds a padding between both components.

Open in GitHub Codespaces

Changelog

CHANGELOG entry: Fixes navigation between multichain account screens
CHANGELOG entry: Fixes padding between ShowHideToggle and TextField in ImportSrp screen

Related issues

Fixes: #34607

Manual testing steps

Bug 1

  1. Navigate Account List > Wallet Detail > Account Detail > QR Code
  2. Navigate back until you get back to Wallet view. It should skip the Wallet Detail and Account List

Bug 2

  1. Navigate to import SRP
  2. Notice the style of ShowHideToggle is fixed

Screenshots/Recordings

Before

Check linked issue: #34607

After

Bug 1

Screen.Recording.2025-07-25.at.6.40.10.PM.mov

Bug 2

Screenshot 2025-07-25 at 6 38 48 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr requested a review from a team as a code owner July 25, 2025 22:59
@metamaskbot metamaskbot added the team-accounts-framework Accounts Framework team label Jul 25, 2025
@gantunesr gantunesr changed the title fix: mutlichain accounts minor UX issues cp-13.0.0 fix: multichain accounts minor UX issues cp-13.0.0 Jul 25, 2025
@gantunesr gantunesr changed the title fix: multichain accounts minor UX issues cp-13.0.0 fix: multichain accounts minor UX bugs cp-13.0.0 Jul 25, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔑 @MetaMask/accounts-engineers (2 files, +7 -7)
  • 📁 ui/
    • 📁 pages/
      • 📁 multichain-accounts/
        • 📁 base-account-details/
          • 📄 base-account-details.test.tsx +6 -6
          • 📄 base-account-details.tsx +1 -1

@metamaskbot
Copy link
Collaborator

Builds ready [0ac7095]
UI Startup Metrics (1305 ± 58 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1305117415575813321404
load112898414406011611223
domContentLoaded112097814376311551213
domInteractive18144671740
firstPaint68978122245911361185
backgroundConnect25423935513257273
firstReactRender20146872134
getState10380111229
initialActions20163113
loadScripts873742119062907957
setupStore73253612
WebpackHomeuiStartup24411905299220625432910
load19511413259121820602355
domContentLoaded19411405256821220492305
domInteractive2313220311568
firstPaint1666241570189359
backgroundConnect48143027432289
firstReactRender1539033952183249
getState2344346311236
initialActions9217424614
loadScripts19341401243620420472292
setupStore176230301626
FirefoxBrowserifyHomeuiStartup14541266212615414671816
load1261110915929412981474
domContentLoaded1261110915929412981474
domInteractive1043730553105276
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2614168182746
firstReactRender26196282850
getState11317721938
initialActions30164213
loadScripts1238109315668712791416
setupStore12320529732
WebpackHomeuiStartup17361527239316518232042
load14731272191112615751691
domContentLoaded14731272191112615741690
domInteractive1063439554109172
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect3020245243259
firstReactRender53416655662
getState103211211018
initialActions8021025329
loadScripts14481252172512015511662
setupStore154250311055
Benchmark value 1305 exceeds gate value 1234 for chrome browserify home mean uiStartup
Benchmark value 1129 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1120 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 254 exceeds gate value 10 for chrome browserify home mean backgroundConnect
Benchmark value 2 exceeds gate value 1 for chrome browserify home mean initialActions
Benchmark value 874 exceeds gate value 830 for chrome browserify home mean loadScripts
Benchmark value 1404 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1223 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1213 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 273 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions
Benchmark value 958 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2442 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1952 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1942 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 23 exceeds gate value 21 for chrome webpack home mean domInteractive
Benchmark value 49 exceeds gate value 40 for chrome webpack home mean backgroundConnect
Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions
Benchmark value 1934 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2910 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2356 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 2306 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded
Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive
Benchmark value 360 exceeds gate value 334 for chrome webpack home p95 firstPaint
Benchmark value 290 exceeds gate value 90 for chrome webpack home p95 backgroundConnect
Benchmark value 236 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions
Benchmark value 2292 exceeds gate value 1970 for chrome webpack home p95 loadScripts
Benchmark value 1455 exceeds gate value 1405 for firefox browserify home mean uiStartup
Benchmark value 1261 exceeds gate value 1245 for firefox browserify home mean load
Benchmark value 1261 exceeds gate value 1239 for firefox browserify home mean domContentLoaded
Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect
Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender
Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions
Benchmark value 1239 exceeds gate value 1230 for firefox browserify home mean loadScripts
Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore
Benchmark value 1816 exceeds gate value 1660 for firefox browserify home p95 uiStartup
Benchmark value 276 exceeds gate value 195 for firefox browserify home p95 domInteractive
Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState
Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions
Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore
Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup
Benchmark value 1474 exceeds gate value 1380 for firefox webpack home mean load
Benchmark value 1473 exceeds gate value 1380 for firefox webpack home mean domContentLoaded
Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive
Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect
Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender
Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions
Benchmark value 1449 exceeds gate value 1360 for firefox webpack home mean loadScripts
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Benchmark value 2042 exceeds gate value 1935 for firefox webpack home p95 uiStartup
Benchmark value 1691 exceeds gate value 1660 for firefox webpack home p95 load
Benchmark value 1690 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded
Benchmark value 172 exceeds gate value 156 for firefox webpack home p95 domInteractive
Benchmark value 59 exceeds gate value 49 for firefox webpack home p95 backgroundConnect
Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender
Benchmark value 29 exceeds gate value 2 for firefox webpack home p95 initialActions
Benchmark value 1662 exceeds gate value 1630 for firefox webpack home p95 loadScripts
Benchmark value 55 exceeds gate value 28 for firefox webpack home p95 setupStore
Sum of mean exceeds: 1994ms | Sum of p95 exceeds: 2643.8ms
Sum of all benchmark exceeds: 4637.8ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 38 Bytes (0%)
  • ui: 28 Bytes (0%)
  • common: 15 Bytes (0%)

@gantunesr
Copy link
Member Author

Closed in favour of #34679

@gantunesr gantunesr closed this Jul 28, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-accounts-framework Accounts Framework team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Back button on Account Details not working

3 participants