-
Notifications
You must be signed in to change notification settings - Fork 5.5k
fix: multichain accounts minor UX bugs cp-13.0.0 #34644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✨ Files requiring CODEOWNER review ✨🔑 @MetaMask/accounts-engineers (2 files, +7 -7)
|
Collaborator
Builds ready [0ac7095]
UI Startup Metrics (1305 ± 58 ms)
Benchmark value 1129 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1120 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 254 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 2 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 874 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1404 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1223 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1213 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 1185 exceeds gate value 1180 for chrome browserify home p95 firstPaint Benchmark value 273 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 13 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 958 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2442 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1952 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1942 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 23 exceeds gate value 21 for chrome webpack home mean domInteractive Benchmark value 49 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 9 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 1934 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2910 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2356 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2306 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 68 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 360 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 290 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 236 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 14 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2292 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 1455 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1261 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1261 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 26 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 27 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1239 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 12 exceeds gate value 9 for firefox browserify home mean setupStore Benchmark value 1816 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 276 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 38 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 13 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 32 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 1736 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 1474 exceeds gate value 1380 for firefox webpack home mean load Benchmark value 1473 exceeds gate value 1380 for firefox webpack home mean domContentLoaded Benchmark value 106 exceeds gate value 100 for firefox webpack home mean domInteractive Benchmark value 31 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 9 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 1449 exceeds gate value 1360 for firefox webpack home mean loadScripts Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore Benchmark value 2042 exceeds gate value 1935 for firefox webpack home p95 uiStartup Benchmark value 1691 exceeds gate value 1660 for firefox webpack home p95 load Benchmark value 1690 exceeds gate value 1660 for firefox webpack home p95 domContentLoaded Benchmark value 172 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 59 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 29 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 1662 exceeds gate value 1630 for firefox webpack home p95 loadScripts Benchmark value 55 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 1994ms | Sum of p95 exceeds: 2643.8ms Sum of all benchmark exceeds: 4637.8ms Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Member
Author
|
Closed in favour of #34679 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves 2 issues,
ShowHideTogglein the import SRP screen was glued to the input box, this adds a padding between both components.Changelog
CHANGELOG entry: Fixes navigation between multichain account screens
CHANGELOG entry: Fixes padding between
ShowHideToggleandTextFieldinImportSrpscreenRelated issues
Fixes: #34607
Manual testing steps
Bug 1
Bug 2
ShowHideToggleis fixedScreenshots/Recordings
Before
Check linked issue: #34607
After
Bug 1
Screen.Recording.2025-07-25.at.6.40.10.PM.mov
Bug 2
Pre-merge author checklist
Pre-merge reviewer checklist