fix: flaky test Multichain Aggregated Balances shows correct aggregated balance when "Current Network" is selected (#34856)
#34877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted balance when "Current Network" is selected` (#34856) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This test uses an anti-pattern that we should avoid. See more context on this issue here: #19870 There's a work being done to avoid this as a lint rule, but it hasn't been finished yet [](https://codespaces.new/MetaMask/metamask-extension/pull/34856?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: #34798 ## **Manual testing steps** 1. `yarn test:e2e:single --browser chrome test/e2e/tests/multichain/aggregated-balances.spec.ts --leave-running=true` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨👨🔧 @MetaMask/qa (1 files, +4 -8)
|
Collaborator
Builds ready [939db78]
UI Startup Metrics (1234 ± 48 ms)
Benchmark value 220 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 3 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 841 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 230 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 10 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2411 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1915 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1904 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 74 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1897 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2745 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2207 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2186 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 290 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 9 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2174 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 186 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 1471 exceeds gate value 1405 for firefox browserify home mean uiStartup Benchmark value 1269 exceeds gate value 1245 for firefox browserify home mean load Benchmark value 1269 exceeds gate value 1239 for firefox browserify home mean domContentLoaded Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 6 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1246 exceeds gate value 1230 for firefox browserify home mean loadScripts Benchmark value 1678 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 230 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 39 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 40 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 1619 exceeds gate value 1615 for firefox webpack home mean uiStartup Benchmark value 34 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 53 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 245 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 60 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 62 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 1257ms | Sum of p95 exceeds: 1626.8ms Sum of all benchmark exceeds: 2883.8ms |
DDDDDanica
approved these changes
Aug 6, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| await this.driver.waitForSelector({ | ||
| css: this.assetValue, | ||
| text: value, | ||
| }); |
There was a problem hiding this comment.
Bug: Refactoring Hides Specific Test Failures
The refactored checkAccountValueAndSuffix method removes detailed error reporting. It replaces an explicit assertion that provided specific "expected vs. actual" value messages with waitForSelector's text matching. This change results in generic timeout errors instead of informative messages, making it significantly harder to debug test failures when the element exists but contains unexpected text.
gauthierpetetin
changed the title
Multichain Aggregated Balances shows correct aggregated balance when "Current Network" is selected (#34856)
Collaborator
Builds ready [75c0cd7]
UI Startup Metrics (1271 ± 65 ms)
Benchmark value 1093 exceeds gate value 1070 for chrome browserify home mean load Benchmark value 1086 exceeds gate value 1061 for chrome browserify home mean domContentLoaded Benchmark value 224 exceeds gate value 10 for chrome browserify home mean backgroundConnect Benchmark value 2 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 869 exceeds gate value 830 for chrome browserify home mean loadScripts Benchmark value 1384 exceeds gate value 1365 for chrome browserify home p95 uiStartup Benchmark value 1204 exceeds gate value 1190 for chrome browserify home p95 load Benchmark value 1191 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded Benchmark value 237 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 7 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 969 exceeds gate value 940 for chrome browserify home p95 loadScripts Benchmark value 2348 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 1858 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 1843 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 71 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 1836 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 2707 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2283 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2133 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 79 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 292 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 12 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2119 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 27 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 26 exceeds gate value 25 for firefox browserify home mean firstReactRender Benchmark value 4 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 201 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 35 exceeds gate value 24 for firefox browserify home p95 getState Benchmark value 21 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 28 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 32 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 51 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 229 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 52 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 61 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 14 exceeds gate value 2 for firefox webpack home p95 initialActions Sum of mean exceeds: 979ms | Sum of p95 exceeds: 1445.8ms Sum of all benchmark exceeds: 2424.8ms |
metamaskbot
added
the
release-13.1.0
Collaborator
|
No release label on PR. Adding release label release-13.1.0 on PR, as PR was added to branch 13.1.0 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
](https://codespaces.new/MetaMask/metamask-extension/pull/34856?quickstart=1){kind=link}
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This test uses an anti-pattern that we should avoid. See more context on this issue here:
#19870
There's a work being done to avoid this as a lint rule, but it hasn't been finished yet
Changelog
CHANGELOG entry:
Related issues
Fixes: #34798
Manual testing steps
yarn test:e2e:single --browser chrome test/e2e/tests/multichain/aggregated-balances.spec.ts --leave-running=trueScreenshots/Recordings
Before
After
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist