release(runway): cherry-pick fix: bump solana snap #34990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the Solana Snap to [v2.1.4](https://github.com/MetaMask/snap-solana-wallet/releases/tag/v2.1.4), bringing in the following: - Changed - Enhance performance by triggering UI refresh jobs only when the UI is open (MetaMask/snap-solana-wallet#490) - Fixed - Increase the compute unit limit used for sending SPL tokens (MetaMask/snap-solana-wallet#492) - Ensure WebSocket connections are open whenever the client becomes active (MetaMask/snap-solana-wallet#489) <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fixes: 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Alejandro Garcia Anglada <[email protected]> Co-authored-by: MetaMask Bot <[email protected]>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
metamaskbot
added
the
team-runway-bot-deprecated
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Collaborator
✨ Files requiring CODEOWNER review ✨🧩 @MetaMask/extension-devs (4 files, +0 -4)
📜 @MetaMask/policy-reviewers (4 files, +0 -4)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (4 files, +0 -4)
|
Collaborator
Builds ready [f515611]
UI Startup Metrics (1164 ± 63 ms)
Benchmark value 4 exceeds gate value 1 for chrome browserify home mean initialActions Benchmark value 229 exceeds gate value 18 for chrome browserify home p95 backgroundConnect Benchmark value 15 exceeds gate value 1.2 for chrome browserify home p95 initialActions Benchmark value 2745 exceeds gate value 2192 for chrome webpack home mean uiStartup Benchmark value 2102 exceeds gate value 1711 for chrome webpack home mean load Benchmark value 2091 exceeds gate value 1704 for chrome webpack home mean domContentLoaded Benchmark value 213 exceeds gate value 199 for chrome webpack home mean firstPaint Benchmark value 71 exceeds gate value 40 for chrome webpack home mean backgroundConnect Benchmark value 43 exceeds gate value 29 for chrome webpack home mean getState Benchmark value 17 exceeds gate value 7 for chrome webpack home mean initialActions Benchmark value 2085 exceeds gate value 1699 for chrome webpack home mean loadScripts Benchmark value 3080 exceeds gate value 2454 for chrome webpack home p95 uiStartup Benchmark value 2471 exceeds gate value 2030 for chrome webpack home p95 load Benchmark value 2453 exceeds gate value 2005 for chrome webpack home p95 domContentLoaded Benchmark value 62 exceeds gate value 57 for chrome webpack home p95 domInteractive Benchmark value 418 exceeds gate value 334 for chrome webpack home p95 firstPaint Benchmark value 350 exceeds gate value 90 for chrome webpack home p95 backgroundConnect Benchmark value 402 exceeds gate value 370 for chrome webpack home p95 firstReactRender Benchmark value 261 exceeds gate value 195 for chrome webpack home p95 getState Benchmark value 182 exceeds gate value 7 for chrome webpack home p95 initialActions Benchmark value 2435 exceeds gate value 1970 for chrome webpack home p95 loadScripts Benchmark value 215 exceeds gate value 65 for chrome webpack home p95 setupStore Benchmark value 31 exceeds gate value 25 for firefox browserify home mean backgroundConnect Benchmark value 5 exceeds gate value 1 for firefox browserify home mean initialActions Benchmark value 1669 exceeds gate value 1660 for firefox browserify home p95 uiStartup Benchmark value 248 exceeds gate value 195 for firefox browserify home p95 domInteractive Benchmark value 11 exceeds gate value 2 for firefox browserify home p95 initialActions Benchmark value 44 exceeds gate value 27 for firefox browserify home p95 setupStore Benchmark value 33 exceeds gate value 26 for firefox webpack home mean backgroundConnect Benchmark value 52 exceeds gate value 38 for firefox webpack home mean firstReactRender Benchmark value 5 exceeds gate value 1 for firefox webpack home mean initialActions Benchmark value 249 exceeds gate value 156 for firefox webpack home p95 domInteractive Benchmark value 78 exceeds gate value 49 for firefox webpack home p95 backgroundConnect Benchmark value 63 exceeds gate value 50 for firefox webpack home p95 firstReactRender Benchmark value 50 exceeds gate value 32 for firefox webpack home p95 getState Benchmark value 15 exceeds gate value 2 for firefox webpack home p95 initialActions Benchmark value 34 exceeds gate value 28 for firefox webpack home p95 setupStore Sum of mean exceeds: 2031ms | Sum of p95 exceeds: 3236.8ms Sum of all benchmark exceeds: 5267.8ms |
Contributor
|
Regarding socket alert, this happens almost every time we bump. There was not change regarding |
Contributor
|
@SocketSecurity ignore npm/@metamask/[email protected] |
metamaskbot
added
the
release-13.1.0
Collaborator
|
No release label on PR. Adding release label release-13.1.0 on PR, as PR was cherry-picked in branch 13.1.0. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps the Solana Snap to
v2.1.4,
bringing in the following:
open (fix: refresh crons snap-solana-wallet#490)
(fix: bump send SPL compute unit limit snap-solana-wallet#492)
active (Fixes and Performance Improvements snap-solana-wallet#489)
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask
Extension Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Co-authored-by: Alejandro Garcia Anglada [email protected]
Co-authored-by: MetaMask Bot [email protected] ad08b4e