Skip to content

Conversation

@salimtb
Copy link
Contributor

@salimtb salimtb commented Dec 13, 2025

Description

remove duplicated calls to account api v2

Open in GitHub Codespaces

Changelog

CHANGELOG entry: remove duplicated calls to account api v2

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

💎 @MetaMask/metamask-assets (1 files, +4 -0)
  • 📁 ui/
    • 📁 components/
      • 📁 app/
        • 📁 assets/
          • 📁 asset-list/
            • 📁 asset-list-control-bar/
              • 📄 asset-list-control-bar.tsx +4 -0

@metamaskbot
Copy link
Collaborator

Builds ready [fdffc61]
UI Startup Metrics (1270 ± 100 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12701063161110013151434
load104886512859111011177
domContentLoaded104286012819110951170
domInteractive261593192290
firstPaint59382119041910651151
backgroundConnect2091912418213224
firstReactRender463277104970
getState3518101114056
initialActions102112
loadScripts840662107590895964
setupStore1165661223
numNetworkReqs171176171168
BrowserifyPower User HomeuiStartup19431641248916720342259
load1065884159712711631249
domContentLoaded1054876157712611541244
domInteractive3017123222792
firstPaint5549015974189961222
backgroundConnect253201703111226578
firstReactRender48396445156
getState19114068359212243
initialActions102112
loadScripts84567613441249401034
setupStore1573561432
numNetworkReqs67551301765113
WebpackStandard HomeuiStartup8646861255979211030
load668574102085727826
domContentLoaded663569101185722821
domInteractive2916523522375
firstPaint23877808168224638
backgroundConnect246137283092
firstReactRender63363095051207
getState301565123956
initialActions104112
loadScripts66056799784720818
setupStore1153851322
numNetworkReqs171170161167
WebpackPower User HomeuiStartup14111031212318515001759
load69055791185713865
domContentLoaded68455190485701859
domInteractive30151522626100
firstPaint346102881229611754
backgroundConnect70867512691530
firstReactRender51418075461
getState18914764153200243
initialActions103111
loadScripts68054989684698849
setupStore1484181335
numNetworkReqs70542403063124
FirefoxBrowserifyStandard HomeuiStartup13471070194117414331760
load1042896134010411101239
domContentLoaded1042895133910411101239
domInteractive59302273584125
firstPaint------
backgroundConnect54232334771179
firstReactRender40316794559
getState14696151334
initialActions103122
loadScripts101787912789410711187
setupStore155148201645
numNetworkReqs19981191376
BrowserifyPower User HomeuiStartup25811640382654830233224
load1620976249149220872253
domContentLoaded1620976249149220872253
domInteractive9930113317872316
firstPaint------
backgroundConnect192211210252203992
firstReactRender543395115973
getState1407529546160249
initialActions41739230
loadScripts1508956227045219532196
setupStore3943566234162
numNetworkReqs70521111886108
WebpackStandard HomeuiStartup16731301209317417832017
load13591109181212114441554
domContentLoaded13591109181112114441554
domInteractive83293754898146
firstPaint------
backgroundConnect711922143108154
firstReactRender44357874758
getState177180211658
initialActions106122
loadScripts13181096174210913861506
setupStore186182241574
numNetworkReqs191079191376
WebpackPower User HomeuiStartup26831750392752430593549
load18821157268447523132547
domContentLoaded18821156268447523132547
domInteractive208291030323145998
firstPaint------
backgroundConnect151201169198193430
firstReactRender553996125987
getState1326930051163234
initialActions2035323
loadScripts17991143266045122152490
setupStore3453565730156
numNetworkReqs70511352078111
📊 Page Load Benchmark Results

Current Commit: fdffc61 | Date: 12/13/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.06s (±75ms) 🟡 | historical mean value: 1.05s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 745ms (±72ms) 🟢 | historical mean value: 732ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 79ms (±15ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.06s 75ms 1.01s 1.44s 1.29s 1.44s
domContentLoaded 745ms 72ms 700ms 1.10s 971ms 1.10s
firstPaint 79ms 15ms 64ms 216ms 92ms 216ms
firstContentfulPaint 79ms 15ms 64ms 216ms 92ms 216ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 639 Bytes (0.01%)
  • ui: 50 Bytes (0%)
  • common: 592 Bytes (0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants