fix: improve add tokens through polling #7469
Open
+652
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salimtb
commented
Dec 12, 2025
| this.#balanceFetchers = [ | ||
| ...(accountsApiChainIds().length > 0 && allowExternalServices() | ||
| ? [this.#createAccountsApiFetcher()] | ||
| : []), |
Contributor
Author
There was a problem hiding this comment.
we should not do this at the constructor level , this is init only when the worker restart , the new approach will have it changing even when the worker doesn't restart
salimtb
commented
Dec 12, 2025
| return { | ||
| // Dynamically check allowExternalServices() at call time, not just at construction time | ||
| supports: (chainId: ChainIdHex): boolean => | ||
| this.#allowExternalServices() && |
Contributor
Author
There was a problem hiding this comment.
we consider chains not supported for api fetch if basic func is off
salimtb
commented
Dec 12, 2025
| // This fixes a bug where the cache from construction time could be stale/empty | ||
| const { tokensChainsCache } = this.messenger.call( | ||
| 'TokenListController:getState', | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
same here , we should fetch this value from the state to ensure we get last updated data
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
TokenBalancesControllerto evaluateallowExternalServicesdynamically instead of only at constructor time.#balanceFetchersarray was built once in the constructor, so changes toallowExternalServices()after initialization were not reflectedallowExternalServices()is stored as a function and evaluated dynamically in the fetcher'ssupportsmethodTokenDetectionControllermethodsaddDetectedTokensViaPollingandaddDetectedTokensViaWsto refresh token metadata cache before use#tokensChainsCachefrom construction timetokensChainsCachefromTokenListController:getStatebefore looking up token metadataExtension UI: MetaMask/metamask-extension#38841
Mobile UI: MetaMask/metamask-mobile#23864
References
Checklist
Note
Introduce onboarding-aware balance fetching, dynamic allowExternalServices checks, and fresh token metadata usage, with refactors and tests across balances and detection controllers.
isOnboardedoption;isActivenow requires unlocked + onboarded.supports()now evaluatesallowExternalServices()dynamically.isOnboardedoption; skiprefresh/syncBalanceWithAddresseswhen not onboarded.fromandtoaddresses on tx events.unprocessedChainIdsfallback; tighten typings, privatizesyncAccounts, safer event handling.tokensChainsCacheat call-time foraddDetectedTokensViaPolling/addDetectedTokensViaWs.CHANGELOG.mdwith added options and fixes; add mocks tests for Accounts API balances.Written by Cursor Bugbot for commit cb4a07d. This will update automatically on new commits. Configure here.