-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: New nft details page #10277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New nft details page #10277
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
|
tommasini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This work is awesome, left some questions!
|
tommasini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's re run the E2E and only merge when they are all green!
|
|



Description
This PR modifies the design of the NFT details page.
Designs: https://www.figma.com/design/TfVzSMJA8KwpWX8TTWQ2iO/Asset-list-and-details?node-id=1242-143952&m=dev
Related issues
Fixes:
Related: MetaMask/core#4522
Related: MetaMask/core#4443
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2024-07-18.at.16.29.09.mov
After
after.mov
Also we added a new bottom sheet when token ID is too long
Screen.Recording.2024-07-27.at.22.03.22.mov
Pre-merge author checklist
Pre-merge reviewer checklist